Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create callback queue to run callbacks in order #191

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

josefarias
Copy link
Owner

Closes #180

Relying on callbacks kicked off by server streams is prone to race conditions when actions happen in rapid sequence.

In the case of the linked issue, we were calling the this._selectOnQuery branch after locking in selection:

if () {
  // ...
}
else if (inputType && inputType !== "hw:lockInSelection") {
  if (delay) await sleep(delay)
  this._selectOnQuery(inputType)
}

This fix works but I want to clean it up before merging

@josefarias josefarias merged commit 4bfb641 into main Jul 30, 2024
2 checks passed
@josefarias josefarias deleted the jose/queue-callbacks branch July 30, 2024 03:04
@josefarias josefarias added internal bug Something isn't working labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dismissing dialog after editing selection in async combobox loses hidden value
1 participant