Make passed focusTrapOptions immutable
#35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent CI runs of ember-bootstrap for Ember canary and beta started to fail because of deprecations, raised by mutating the `{{hash}}` object inside of this modifier when it is used to pass `focusTrapOptions` as in https://github.com/josemarluedke/ember-focus-trap#with-focus-trap-options. This deprecation was recently added to Ember in emberjs/ember.js#19548. The change here treats that object as immutable.
|
Ah btw, I didn't add a test here because that scenario is basically already covered by https://github.com/josemarluedke/ember-focus-trap/blob/main/tests/integration/modifiers/focus-trap-test.js#L36. It's just that for now this is only a deprecation. You could setup tests to throw on a deprecation, but that comes with its own drawbacks (failing CI due to deprecations in dependencies), and seems at least out of scope for this PR. |
backspace
added a commit
to cardstack/cardstack
that referenced
this pull request
Jul 25, 2022
This was addressed in ember-focus-trap: josemarluedke/ember-focus-trap#35
backspace
added a commit
to cardstack/cardstack
that referenced
this pull request
Jul 25, 2022
This was addressed in ember-focus-trap: josemarluedke/ember-focus-trap#35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent CI runs of ember-bootstrap for Ember canary and beta started to fail because of deprecations, raised by mutating the
{{hash}}object inside of this modifier when it is used to passfocusTrapOptionsas in https://github.com/josemarluedke/ember-focus-trap#with-focus-trap-options. This deprecation was recently added to Ember in emberjs/ember.js#19548. The change here treats that object as immutable.