Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup flow is confusing #18

Open
josephfrazier opened this issue Jun 17, 2018 · 3 comments
Open

Signup flow is confusing #18

josephfrazier opened this issue Jun 17, 2018 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@josephfrazier
Copy link
Owner

josephfrazier commented Jun 17, 2018

From conversation around https://reportedcab.slack.com/messages/C9VNM3DL4/p1529182432000011:

$BUG_REPORTER [4:49 PM]
It's asking for a password. Do I have one if I've only used the iOS app?

jeff [4:49 PM]
i think you have to register again but it should sync

$BUG_REPORTER [4:51 PM]
I'm getting an error: "Error: Please verify $THE_EMAIL_ADDRESS and try again. You should have received a message." Is that just it's way of saying "Please confirm your email address"?

jeff [4:51 PM]
did you check your email? i think joseph added email validation in the web app.

$BUG_REPORTER [4:51 PM]
Then it sent two confirmation emails each with a different confirmation URL.
The success page doesn't give any link to move forward. So I'll went back to the other page and reloaded and it looked the same. So I resubmitted the form and it now lets me do stuff. That's a weird set of events to say the least.

There's at least 3 issues here:

  1. The password field is confusing (we should differentiate the UI between signup and login (see slack), and maybe note relationship to iOS/Android). See also Add "Sign Up / Log In" button to load previously entered info #21
  2. The prompt to confirm the email address is confusing See Clarify email confirmation prompt #20
  3. The flow after email confirmation isn't clear See below
  4. Then it sent two confirmation emails each with a different confirmation URL

@josephfrazier josephfrazier added the bug Something isn't working label Jun 17, 2018
@josephfrazier josephfrazier self-assigned this Jun 17, 2018
@josephfrazier
Copy link
Owner Author

  1. The flow after email confirmation isn't clear

I've added the following text to the email confirmation and password reset emails, to improve this a bit. Ideally, the confirmation/reset links would lead back to the app, but I don't know if that's possible with Back4App.

Afterwards, click here to log in:
https://reported-web.herokuapp.com

josephfrazier added a commit that referenced this issue Jun 19, 2018
This addresses part of #18
josephfrazier added a commit that referenced this issue Jun 19, 2018
This partially addresses #18
by making it easier for returning users to log in on a different browser/device
(where they don't have everything in localStorage).

Note the TODO in the code.
josephfrazier added a commit that referenced this issue Jun 20, 2018
josephfrazier added a commit that referenced this issue Jun 24, 2018
This partially addresses #18
by making it easier for returning users to log in on a different browser/device
(where they don't have everything in localStorage).
@josephfrazier
Copy link
Owner Author

Then it sent two confirmation emails each with a different confirmation URL

I think this is because both the signUp and the logIn SDK methods are each causing an email. Hopefully there's a way to detect this upon signUp and avoid trying logIn afterwards.

@josephfrazier
Copy link
Owner Author

Bumping this with https://reportedcab.slack.com/archives/C852Q265V/p1565900149035900?thread_ts=1565899662.033400&cid=C852Q265V

I think it effectively tried to perform a password reset/new account creation, even though I already had an account under that id, and I didn't ask it to do either thing. It obviously failed at whatever it tried (couldn't log me into the web app), but also invalidated my mobile session, and I couldn't get it to accept the old password anymore (whatever was stored in my iPhone keyring).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant