Parse EXIF metadata from HEIC files properly #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephfrazier
temporarily deployed
to
github-heic-exif-p77udzexaauvf
josephfrazier
added a commit
that referenced
this pull request
Feb 17, 2021
This reverts commit 4f72795, which appears to be breaking image uploads generally, see https://reportedcab.slack.com/archives/C9VNM3DL4/p1613595901000200: > Photos are currently broken on the web app (I upload photos, they appear to go up, but the 311 confirmation emails have blank photos, and the tweets don’t have photos) and TODO: > Maybe the changes to [server.js](c0af3f4...master#diff-79f4c7cdc0b026f6e556196f5911a449157807cffdb3f9d33f0b5404b4ffc2f3)? like line 440?
josephfrazier
added a commit
that referenced
this pull request
Feb 17, 2021
This reverts commit 4f72795, which appears to be breaking image uploads generally, see https://reportedcab.slack.com/archives/C9VNM3DL4/p1613595901000200: > Photos are currently broken on the web app (I upload photos, they appear to go up, but the 311 confirmation emails have blank photos, and the tweets don’t have photos) and https://reportedcab.slack.com/archives/C9VNM3DL4/p1613603304019100?thread_ts=1613595901.000200&cid=C9VNM3DL4: > Maybe the changes to [server.js](c0af3f4...master#diff-79f4c7cdc0b026f6e556196f5911a449157807cffdb3f9d33f0b5404b4ffc2f3)? like line 440?
josephfrazier
added a commit
that referenced
this pull request
Feb 18, 2021
josephfrazier
added a commit
that referenced
this pull request
Feb 19, 2021
…274)" (#276) slack discussion at https://reportedcab.slack.com/archives/C9VNM3DL4/p1613609155034100 * This reverts commit 8a17e20. * Update snapshots with `yarn test -u` * Finish awaiting FileType promise before reading property
josephfrazier
added a commit
that referenced
this pull request
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #261