Parse time zone from Nikon images #319
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…funkel.tumblr.com/post/5768232136/navigating-the-makernote-hell Might be able to use https://github.com/mattburns/exiftool.js/ instead, looks like it may have support
josephfrazier
temporarily deployed
to
reported-web-nikon-exif-rs8sev
josephfrazier
temporarily deployed
to
reported-web-nikon-exif-rs8sev
|
exiftool.js isn't working either:
|
josephfrazier
added a commit
that referenced
this pull request
Dec 8, 2021
This should help alleviate the problem that #319 is trying to solve. Note that it's not foolproof, due to the inherent ambiguity of expressing times without timezones. Specifically, photos taken during the hour that occurs twice when we switch from EDT to EST, may not have the correct timezone applied. Most of the code in timezone.js came from https://www.codeproject.com/articles/58728/javascript-code-to-determine-when-daylight-savings
josephfrazier
added a commit
that referenced
this pull request
Dec 8, 2021
…323) * Guess timezone from CreateDate if OffsetTimeDigitized is not present This should help alleviate the problem that #319 is trying to solve. Note that it's not foolproof, due to the inherent ambiguity of expressing times without timezones. Specifically, photos taken during the hour that occurs twice when we switch from EDT to EST, may not have the correct timezone applied. Most of the code in timezone.js came from https://www.codeproject.com/articles/58728/javascript-code-to-determine-when-daylight-savings * Use positive offsets instead of negative A test photo was showing up as 6:46pm rather than the correct value of 10:46am, which tipped me off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Image: https://share.icloud.com/photos/0uo0pKEN5AcHE_o7d05B_pGfA#Madison_Square_Park
This is a follow-up to #317
Hmm, there's also the
GPSTimeStampfield, which appears to be in GMT (14:42:45.74) and is generally close to the CreateDate time (a few minutes off), so we might be able to use it to infer the timezone.Resources:
https://exif.online can extract the Time Zone, just need to figure out how to get JS to do it:
This partially addresses #318
XXX Try parsing MakerNote, but it has its own format, see https://gomfunkel.tumblr.com/post/5768232136/navigating-the-makernote-hell
Might be able to use https://github.com/mattburns/exiftool.js/ instead,
looks like it may have support