Add colorless frames for Classicshifted #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graphic Design is my Passion:tm:
Adds colorless frames for the Classicshifted pack. I edited the existing frames to add a gray overlay over the artifact frames and change the textbox to be the same kind of khaki-brown as the official retro frame released with MH3.
In addition, I made the M15 down arrow transform symbol visible in the frame selection and also updated the Classicshifted transform group (which uses the same icons, just with slightly different bounds) with the icons added since its release.
When locally testing I get a recursion error trying to add a crown to the frame - something about
complementary:24not being liked by the frame builder. @joshbirnholz could you test this PR as well and see if you see the same behaviour? The live version doesn't have it for me so I assume this is something being weird with my local install. If you can add a Classicshifted crown to the card this should be fine to release.