Add Japanese Showcase & Holostamp (DSK) #45
Conversation
Norimoo
commented
Sep 25, 2024
Norimoo
commented
- Added template: Japanese Showcase template from Duskmourn
- Modified template: Showcase Holostamp template extended with JP Showcase holostamps
- Added template: Japanese Showcase template from Duskmourn - Modified template: Showcase Holostamp template extended with JP Showcase holostamps
js/frameSearch.js
Outdated
| @@ -41,6 +41,7 @@ const frameNames = new Map ([ | |||
| ['Brawl Legend Crowns', 'Brawl'], | |||
| //showcase | |||
| ['Paranormal (DSK)', 'Paranormal'], | |||
| ['Japanese (DSK)', 'JapaneseShowcase'], | |||
There was a problem hiding this comment.
Can we call this "Japan Showcase" instead of Japanese Showcase?
js/frames/groupShowcase-5.js
Outdated
| @@ -1,6 +1,7 @@ | |||
| loadFramePacks([ | |||
| {name:'Set Showcase Frames (Chronological)', value:'disabled'}, | |||
| {name:'Paranormal (DSK)', value:'Paranormal'}, | |||
| {name:'Japanese (DSK)', value:'JapaneseShowcase'}, | |||
There was a problem hiding this comment.
It sounds like Wizards will be re-using this frame going forward. It won't be exclusive to Duskmourn. Can we group this next to the borderless cards instead of with the other showcase cards?
| @@ -40,6 +40,7 @@ const frameNames = new Map ([ | |||
| ['Colorshifted (Planar Chaos)', 'Colorshifted'], | |||
| ['Brawl Legend Crowns', 'Brawl'], | |||
| //showcase | |||
| ['Japan', 'JapanShowcase'], | |||
There was a problem hiding this comment.
Can we make it say "Japan Showcase" here as well?
| @@ -54,6 +54,7 @@ loadFramePacks([ | |||
| {name:'Generic Showcase Frames', value:'disabled'}, | |||
| {name:'Borderless', value:'GenericShowcase'}, | |||
| {name:'Borderless (Alt)', value:'Borderless'}, | |||
| {name:'Japan', value:'JapanShowcase'}, | |||
There was a problem hiding this comment.
Can we make it say "Japan Showcase" here as well?
| var boundsStamp = {x:0.4365, y:0.902, width:0.1264, height:0.0452}; | ||
| //defines available frames | ||
| availableFrames = [ | ||
| {name:'White Frame', src:'/img/frames/m15/japaneseShowcase/japaneseShowcaseFrameW.png', masks:masks}, |
There was a problem hiding this comment.
Can we make the frame file names be just "w.png", "u.png", etc?
P/T and Holo Stamps can go in their own subdirectory, so the path would be /pt/u.png, and stamps would be /stamp/u.png, for example.
I have been using this naming scheme for my new frames so that they can easily be added to the Autoframe system in the future.
| //defines available frames | ||
| availableFrames = [ | ||
| {name:'White Frame', src:'/img/frames/m15/japaneseShowcase/japaneseShowcaseFrameW.png', masks:masks}, | ||
| {name:'Blue Frame', src:'/img/frames/m15/japaneseShowcase/japaneseShowcaseFrameU.png', masks:masks}, |
There was a problem hiding this comment.
And finally, can we change the "japaneseShowcase" in the filepath here to "japanShowcase"?
