Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.src/cli_plugin/install - kibana cli plugin downloader _downloadSingle http downloader should throw an ENOTFOUND error for a http ulr that returns 404 #23

Closed
joshdover opened this issue Sep 4, 2018 · 2 comments
Closed

Failing test: Jest Tests.src/cli_plugin/install - kibana cli plugin downloader _downloadSingle http downloader should throw an ENOTFOUND error for a http ulr that returns 404 #23

joshdover opened this issue Sep 4, 2018 · 2 comments
Labels
flaky-failing-test

Comments

@joshdover
Copy link
Owner

joshdover commented Sep 4, 2018 •
edited
Loading

A test failed on a tracked branch


        Error: expect(received).toBe(expected) // Object.is equality

Expected value to be:
  true
Received:
  false
    at Object.<anonymous> (/Users/jdover/src/kibana/src/cli_plugin/install/download.test.js:84:25)
    at Object.asyncFn (/Users/jdover/src/kibana/node_modules/jest-jasmine2/build/jasmine_async.js:82:37)
    at resolve (/Users/jdover/src/kibana/node_modules/jest-jasmine2/build/queue_runner.js:52:12)
    at new Promise (<anonymous>)
    at mapper (/Users/jdover/src/kibana/node_modules/jest-jasmine2/build/queue_runner.js:39:19)
    at promise.then (/Users/jdover/src/kibana/node_modules/jest-jasmine2/build/queue_runner.js:73:82)
    at <anonymous>

First failure: Jenkins Build
@joshdover
Copy link
Owner Author

New failure: Jenkins Build

1 similar comment
@joshdover
Copy link
Owner Author

New failure: Jenkins Build

@joshdover joshdover mentioned this issue Sep 4, 2018
Merged
joshdover pushed a commit that referenced this issue Sep 9, 2020
@scottybollinger
[Enterprise Search] Add Overview landing page/plugin (elastic#76734)
d67a421 
* [public] Register Enterprise search plugin

+ move new Home strings to constants

* [server] Register plugin access/visibility

* Set up Enterprise Search Kibana Chrome

- Add SetEnterpriseSearchChrome
- Update Enterprise Search breadcrumbs to link to new overview plugin (+ update overview plugin URL per team discussion)
  - Add ability to break out of React Router basename by not using history.createhref
  - Update createHref mock to more closely match Kibana urls (adding /app prefix)
- Minor documentation fix

* Set up Enterprise Search plugin telemetry

- client-side: SendEnterpriseSearchTelemetry
- server-side: register saved objects, usage collector, etc.

* Enterprise search overview views (#23)

* Add formatTestSubj util

This allows us to correctly format strings into our casing for data-test-subj attrs

* Add images and stylesheet

* Add product card component

* Add index component

* Remove unused styles

* Fix inter-plugin links
- by add shouldNotCreateHref prop to RR helpers
- similiar to breadcrumb change

* Fix/clean up CSS

- Prefer EUI components over bespoke CSS (e.g. EuiCard)
- Remove unused or unspecific CSS
- Pull out product card CSS to its component
- Fix kebab-cased CSS classes to camelCased

* Clean up ProductCard props

- Prefer passing in our plugin consts instead of separate props
- Move productCardDescription to constants
- Update tests

* Add telemetry clicked actions to product buttons

+ revert data-test-subj strings to previous implementation
+ prune format_test_subj helper by using lodash util directly

* [PR feedback] Add new plugin to applicationUsageSchema per telemetry team request

* Fix failing functional navLinks test

* Fix telemetry schema test

* [Perf] Optimize assets size by switching from 300kb SVG to 25kb PNG

* Only show product cards if the user has access to that product

- adds access checks
- fixes flex/CSS to show one card at a time

Co-authored-by: Scotty Bollinger <[email protected]>
joshdover pushed a commit that referenced this issue Sep 10, 2020
@scottybollinger
[Enterprise Search] Add Overview landing page/plugin (elastic#76734) (e…
1e5d67d 
…lastic#77113)

* [public] Register Enterprise search plugin

+ move new Home strings to constants

* [server] Register plugin access/visibility

* Set up Enterprise Search Kibana Chrome

- Add SetEnterpriseSearchChrome
- Update Enterprise Search breadcrumbs to link to new overview plugin (+ update overview plugin URL per team discussion)
  - Add ability to break out of React Router basename by not using history.createhref
  - Update createHref mock to more closely match Kibana urls (adding /app prefix)
- Minor documentation fix

* Set up Enterprise Search plugin telemetry

- client-side: SendEnterpriseSearchTelemetry
- server-side: register saved objects, usage collector, etc.

* Enterprise search overview views (#23)

* Add formatTestSubj util

This allows us to correctly format strings into our casing for data-test-subj attrs

* Add images and stylesheet

* Add product card component

* Add index component

* Remove unused styles

* Fix inter-plugin links
- by add shouldNotCreateHref prop to RR helpers
- similiar to breadcrumb change

* Fix/clean up CSS

- Prefer EUI components over bespoke CSS (e.g. EuiCard)
- Remove unused or unspecific CSS
- Pull out product card CSS to its component
- Fix kebab-cased CSS classes to camelCased

* Clean up ProductCard props

- Prefer passing in our plugin consts instead of separate props
- Move productCardDescription to constants
- Update tests

* Add telemetry clicked actions to product buttons

+ revert data-test-subj strings to previous implementation
+ prune format_test_subj helper by using lodash util directly

* [PR feedback] Add new plugin to applicationUsageSchema per telemetry team request

* Fix failing functional navLinks test

* Fix telemetry schema test

* [Perf] Optimize assets size by switching from 300kb SVG to 25kb PNG

* Only show product cards if the user has access to that product

- adds access checks
- fixes flex/CSS to show one card at a time

Co-authored-by: Scotty Bollinger <[email protected]>

Co-authored-by: Scotty Bollinger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-failing-test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshdover