This repository has been archived by the owner on May 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuajbouw
added
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Nov 18, 2020
This is fairly feature complete up to this point. |
alec-deason
reviewed
Nov 18, 2020
alec-deason
approved these changes
Nov 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. I still have some thoughts on minimizing the API but I want to work with it as is some before I push on that and it's out of scope for this PR anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the big milestones for data optimisation. Now it is possible to have sparse and dense layers as well as layer sprites ordered by Z level!
Changes
Fixed
tiles_to_renderer_parts
(nowdense_tiles_to_renderer_parts
) which pushed ALL the tiles, not just a single layer.Added
API Changed
TileSetter::push
method:MapResult
->TileMapResult
MapError
->TileMapError
Before
After
TileMap::new_chunk_with_tiles
(Sorry! No longer fits in the scope...)Closes
#9 #6