This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
Remove path.replace for leading slash #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWolf81
approved these changes
Nov 2, 2018
There was a problem hiding this comment.
LGTM.
I've tested this on Ubuntu and it's working there as well after fixing my Node issue :) (I had an old version in my vm, see created issue).
I think it was added just because it's looking nicer with-out the first slash but I'm also not sure. Anyway in my opinion it's OK to remove it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
Fixes #320
Summary:
Removing the leading slash was not working for me on Mac. Removing this behavior fixes the issue, but I am not sure why it was there in the first place. Is it necessary on Linux? Should we put it behind a check for OS?