Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Just For Review] - New Jotform PHP Library #13

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

burakdemirtas-jtf
Copy link

[ONLY REVIEW & FEEDBACKS]

I prepared a new PHP library for Jotform APIs.

You can check examples on the My Repo.
Also, you can check the tests.

For now, there is no XML support in the library but I will add it as soon as possible.

You can review the changes and share your feedback to make it better.

Thanks.

@dzhy89
Copy link

dzhy89 commented Mar 27, 2022

@burakdemirtas-jtf thanks, looks great!

I have a few suggestions:

  1. Need ability to work with HIPAA forms, I have already created https://github.com/jotform/jotform-api-php/pull/10 for old client. HIPAA forms base URL is different.
  2. Would be great to use Guzzle HTTP client instead of CURL, it brings async requests and modern opportunities.
  3. Let's cover properties with type hints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants