Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New language: Italian #176

Merged
merged 3 commits into from
Jul 10, 2024
Merged

New language: Italian #176

merged 3 commits into from
Jul 10, 2024

Conversation

lukasitaly
Copy link
Contributor

I have completed the translation of all strings into Italian.

Added all strings with the Italian translation
@jovandeginste
Copy link
Owner

Thank you very much for your contribution! Would you mind running prettier or another linter on the json file, or manually fix the indentation? I can do this too, if you prefer.

@jovandeginste
Copy link
Owner

I also added a few new strings to translate (sorry, should've added those a few weeks ago...)

@lukasitaly
Copy link
Contributor Author

Don't worry about it, I will fix the indentation (you're doing enough for the community already) and translate the new strings. Did you add the new strings in the messages.json file right?
I won't get to it today but tomorrow or on Friday for sure.

Added json indentation and translated newly added strings.
Added the newly added strings
@lukasitaly
Copy link
Contributor Author

Done! And since I am bilingual meaning I speak Italian and German I also added the newly added strings to the German translation file.

Let me know if the indentation isn't what you had in mind.

@jovandeginste jovandeginste merged commit d147274 into jovandeginste:master Jul 10, 2024
1 check passed
@jovandeginste
Copy link
Owner

Looking good now, thank you very much!

@lukasitaly lukasitaly deleted the patch-1 branch July 10, 2024 20:41
@lukasitaly
Copy link
Contributor Author

You're welcome, thank you for all your work! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants