win: bring back xp/2k3 support #25367
Conversation
Issue: #25348 The gyp/project files don't explicitly specify a subsystem version, which results in the default being used. The default changed from VS 2010 to VS 2012 and later. Backport e8d0850 from io.js. Original commit message follows: Chrome still runs on Windows XP, so there is no reason that iojs couldn't. PR: nodejs/node#512 Reviewed-by: Ben Noordhuis <[email protected]> (cherry picked from commit e8d0850)
|
cc @joyent/node-coreteam , @piscisaureus |
|
LGTM, thank you @orangemocha 👍 |
|
As far as I know, libuv does not support XP anymore. Are we sure that we could provide support for this platform? |
|
cc @saghul |
|
@indutny By fixing this issue, we want to fix a hard regression (not even being able to run node on XP). This is not a commitment for full support of Windows XP at the same level of any other "supported" platform. As far as I know, there's no formal support commitment from the project to any platform anyway, which is I think one thing that @orangemocha wanted to clarify sooner than later, precisely to set expectations for users when they encounter these types of issues (and hopefully to prevent them from happening). |
Issue: #25348 The gyp/project files don't explicitly specify a subsystem version, which results in the default being used. The default changed from VS 2010 to VS 2012 and later. Backport e8d0850 from io.js. Original commit message follows: Chrome still runs on Windows XP, so there is no reason that iojs couldn't. PR: nodejs/node#512 (cherry picked from commit e8d0850) Reviewed-By: Julien Gilli <[email protected]> PR-URL: #25367
|
My understanding is that including this change in the next release (v0.12.4) can't hurt and fixes a regression for all XP users. Thus, I landed this PR in 3122052 and I'm closing this issue but please feel free to add more comments and continue the discussion around supported platforms. Thank you! |
|
If we will ever decide on merging this into io.js, I suggest we should have a TSC conversation. It doesn't look like that was a proper discussion of this here. |
@indutny |
|
Ah, so it was discussed... Sorry for this then :) |
|
FWIW, in libuv we kind of promised not to break XP/2k3 support in the v1.x
|
Issue: nodejs#25348 The gyp/project files don't explicitly specify a subsystem version, which results in the default being used. The default changed from VS 2010 to VS 2012 and later. Backport 3122052, which itself backports e8d0850 from io.js. Original commit message follows: Chrome still runs on Windows XP, so there is no reason that iojs couldn't. PR: nodejs/node#512 (cherry picked from commit e8d0850) Reviewed-By: Julien Gilli <[email protected]> PR-URL: nodejs#25367 Conflicts: node.gyp
Issue: nodejs#25348 The gyp/project files don't explicitly specify a subsystem version, which results in the default being used. The default changed from VS 2010 to VS 2012 and later. Backport 3122052, which itself backports e8d0850 from io.js. Original commit message follows: Chrome still runs on Windows XP, so there is no reason that iojs couldn't. PR: nodejs/node#512 (cherry picked from commit e8d0850) Reviewed-By: Julien Gilli <[email protected]> PR-URL: nodejs#25367 Conflicts: node.gyp
Issue: nodejs#25348 The gyp/project files don't explicitly specify a subsystem version, which results in the default being used. The default changed from VS 2010 to VS 2012 and later. Backport 3122052, which itself backports e8d0850 from io.js. Original commit message follows: Chrome still runs on Windows XP, so there is no reason that iojs couldn't. PR: nodejs/node#512 (cherry picked from commit e8d0850) Reviewed-By: Julien Gilli <[email protected]> PR-URL: nodejs#25367 Conflicts: node.gyp
Issue: nodejs#25348 The gyp/project files don't explicitly specify a subsystem version, which results in the default being used. The default changed from VS 2010 to VS 2012 and later. Backport 3122052, which itself backports e8d0850 from io.js. Original commit message follows: Chrome still runs on Windows XP, so there is no reason that iojs couldn't. PR: nodejs/node#512 (cherry picked from commit e8d0850) Reviewed-By: Julien Gilli <[email protected]> PR-URL: nodejs#25367 Conflicts: node.gyp
Issue: nodejs#25348 The gyp/project files don't explicitly specify a subsystem version, which results in the default being used. The default changed from VS 2010 to VS 2012 and later. Backport 3122052, which itself backports e8d0850 from io.js. Original commit message follows: Chrome still runs on Windows XP, so there is no reason that iojs couldn't. PR: nodejs/node#512 (cherry picked from commit e8d0850) Reviewed-By: Julien Gilli <[email protected]> PR-URL: nodejs#25367 Conflicts: node.gyp
Issue: #25348 The gyp/project files don't explicitly specify a subsystem version, which results in the default being used. The default changed from VS 2010 to VS 2012 and later. Backport 3122052, which itself backports e8d0850 from io.js. Original commit message follows: Chrome still runs on Windows XP, so there is no reason that iojs couldn't. PR: nodejs/node#512 (cherry picked from commit e8d0850) Reviewed-By: Julien Gilli <[email protected]> PR-URL: #25367 Conflicts: node.gyp Reviewed-By: João Reis <[email protected]> PR-URL: #25569
Issue: #25348
The gyp/project files don't explicitly specify a subsystem version,
which results in the default being used. The default differs between
linked versions, and it changed from VS 2010 to VS 2012 and later.
Backport e8d0850 from io.js.
Original commit message follows:
Chrome still runs on Windows XP, so there is no reason that iojs
couldn't.
PR: nodejs/node#512
Reviewed-by: Ben Noordhuis [email protected]
(cherry picked from commit e8d0850)