win: build fixes #512
Merged
win: build fixes #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM FWIW |
Chrome still runs on Windows XP, so there is no reason that iojs couldn't. PR: nodejs#512 Reviewed-by: Ben Noordhuis <[email protected]>
The duplicate warning was fixed by e1fe270, but returned as of 9f45799. Hopefully this will fix the issue for good. PR: nodejs#512 Reviewed-by: Ben Noordhuis <[email protected]>
piscisaureus
force-pushed
the
win-build-fixes
branch
from
a206373
to
4af5746
Compare
|
gobbledygook to me, but if we get NT5.1 then yay! |
piscisaureus
added a commit
to nodejs/node-v0.x-archive
that referenced
this pull request
May 22, 2015
Issue: #25348 The gyp/project files don't explicitly specify a subsystem version, which results in the default being used. The default changed from VS 2010 to VS 2012 and later. Backport e8d0850 from io.js. Original commit message follows: Chrome still runs on Windows XP, so there is no reason that iojs couldn't. PR: nodejs/node#512 (cherry picked from commit e8d0850) Reviewed-By: Julien Gilli <[email protected]> PR-URL: #25367
misterdjules
pushed a commit
to misterdjules/node
that referenced
this pull request
Jun 19, 2015
Issue: nodejs#25348 The gyp/project files don't explicitly specify a subsystem version, which results in the default being used. The default changed from VS 2010 to VS 2012 and later. Backport 3122052, which itself backports e8d0850 from io.js. Original commit message follows: Chrome still runs on Windows XP, so there is no reason that iojs couldn't. PR: nodejs/node#512 (cherry picked from commit e8d0850) Reviewed-By: Julien Gilli <[email protected]> PR-URL: nodejs#25367 Conflicts: node.gyp
misterdjules
pushed a commit
to misterdjules/node
that referenced
this pull request
Jun 24, 2015
Issue: nodejs#25348 The gyp/project files don't explicitly specify a subsystem version, which results in the default being used. The default changed from VS 2010 to VS 2012 and later. Backport 3122052, which itself backports e8d0850 from io.js. Original commit message follows: Chrome still runs on Windows XP, so there is no reason that iojs couldn't. PR: nodejs/node#512 (cherry picked from commit e8d0850) Reviewed-By: Julien Gilli <[email protected]> PR-URL: nodejs#25367 Conflicts: node.gyp
misterdjules
pushed a commit
to misterdjules/node
that referenced
this pull request
Jun 24, 2015
Issue: nodejs#25348 The gyp/project files don't explicitly specify a subsystem version, which results in the default being used. The default changed from VS 2010 to VS 2012 and later. Backport 3122052, which itself backports e8d0850 from io.js. Original commit message follows: Chrome still runs on Windows XP, so there is no reason that iojs couldn't. PR: nodejs/node#512 (cherry picked from commit e8d0850) Reviewed-By: Julien Gilli <[email protected]> PR-URL: nodejs#25367 Conflicts: node.gyp
misterdjules
pushed a commit
to misterdjules/node
that referenced
this pull request
Jul 21, 2015
Issue: nodejs#25348 The gyp/project files don't explicitly specify a subsystem version, which results in the default being used. The default changed from VS 2010 to VS 2012 and later. Backport 3122052, which itself backports e8d0850 from io.js. Original commit message follows: Chrome still runs on Windows XP, so there is no reason that iojs couldn't. PR: nodejs/node#512 (cherry picked from commit e8d0850) Reviewed-By: Julien Gilli <[email protected]> PR-URL: nodejs#25367 Conflicts: node.gyp
misterdjules
pushed a commit
to misterdjules/node
that referenced
this pull request
Jul 23, 2015
Issue: nodejs#25348 The gyp/project files don't explicitly specify a subsystem version, which results in the default being used. The default changed from VS 2010 to VS 2012 and later. Backport 3122052, which itself backports e8d0850 from io.js. Original commit message follows: Chrome still runs on Windows XP, so there is no reason that iojs couldn't. PR: nodejs/node#512 (cherry picked from commit e8d0850) Reviewed-By: Julien Gilli <[email protected]> PR-URL: nodejs#25367 Conflicts: node.gyp
misterdjules
pushed a commit
to nodejs/node-v0.x-archive
that referenced
this pull request
Jul 23, 2015
Issue: #25348 The gyp/project files don't explicitly specify a subsystem version, which results in the default being used. The default changed from VS 2010 to VS 2012 and later. Backport 3122052, which itself backports e8d0850 from io.js. Original commit message follows: Chrome still runs on Windows XP, so there is no reason that iojs couldn't. PR: nodejs/node#512 (cherry picked from commit e8d0850) Reviewed-By: Julien Gilli <[email protected]> PR-URL: #25367 Conflicts: node.gyp Reviewed-By: João Reis <[email protected]> PR-URL: #25569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@rvagg