-
-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tox, Travis, and Appveyor improvements #157
Conversation
|
||
__version__ = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change this for what I proposed earlier. get_version()
works well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remind me what you proposed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just do the same.
def get_version(package):
"""
Return package version as listed in `__version__` in `init.py`.
"""
init_py = open(os.path.join(package, '__init__.py')).read()
return re.search("__version__ = ['\"]([^'\"]+)['\"]", init_py).group(1)
version = get_version('jwt')
lol I think that's failing because of the é in my first name |
I wonder if this might do. codecs.open(os.path.join(package, '__init__.py'), 'r', 'utf-8').read() |
bcb8cb2
to
0aff2f7
Compare
@mark-adams LGTM, all yours, thanks! I'll get the Appveyor account setup. |
This will need rebasing after merging #159 |
Repo already set at AppVeyor: https://ci.appveyor.com/project/jpadilla/pyjwt |
a801e3e
to
235aa82
Compare
Tox, Travis, and Appveyor improvements
__main__.py
from coveragecc: @jpadilla