Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tox, Travis, and Appveyor improvements #157

Merged
merged 7 commits into from
May 18, 2015

Conversation

mark-adams
Copy link
Contributor

  • Added appveyor support (Thanks @mindw)
  • Added tox configuration improvements (Thanks @mindw)
  • Added travis configuration improvements (Thanks @mindw)
  • Excluded __main__.py from coverage

cc: @jpadilla

@mark-adams mark-adams changed the title Appveyor, Tox, and Travis! Tox, Travis, and Appveyor improvements May 9, 2015
@mark-adams mark-adams mentioned this pull request May 9, 2015

__version__ = None
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this for what I proposed earlier. get_version() works well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remind me what you proposed?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just do the same.

def get_version(package):
    """
    Return package version as listed in `__version__` in `init.py`.
    """
    init_py = open(os.path.join(package, '__init__.py')).read()
    return re.search("__version__ = ['\"]([^'\"]+)['\"]", init_py).group(1)

version = get_version('jwt')

@jpadilla
Copy link
Owner

lol I think that's failing because of the é in my first name

@jpadilla
Copy link
Owner

I wonder if this might do.

codecs.open(os.path.join(package, '__init__.py'), 'r', 'utf-8').read()

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.42%) to 99.58% when pulling a801e3e on mark-adams:tox-and-appveyor into fdd477a on jpadilla:master.

@mark-adams
Copy link
Contributor Author

Coverage won't really go down. Once #159 removes the old Python 3.2-only compatibility code, it'll be back to normal.

What do you think @jpadilla?

@jpadilla
Copy link
Owner

@mark-adams LGTM, all yours, thanks! I'll get the Appveyor account setup.

@jpadilla
Copy link
Owner

This will need rebasing after merging #159

@jpadilla
Copy link
Owner

Repo already set at AppVeyor: https://ci.appveyor.com/project/jpadilla/pyjwt

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 235aa82 on mark-adams:tox-and-appveyor into b4ede91 on jpadilla:master.

jpadilla added a commit that referenced this pull request May 18, 2015
Tox, Travis, and Appveyor improvements
@jpadilla jpadilla merged commit 0ee37ca into jpadilla:master May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants