DeprecationWarnings: more helpful message #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blueyed good stuff, thanks! |
blueyed
added a commit
to blueyed/pyjwt
that referenced
this pull request
Jun 12, 2017
Followup to jpadilla#270: It seems that "verify" is only deprecated with `PyJWS.decode`, which makes sense, since you would have to override a lot of options to skip the verification in `PyJWT._validate_claims`. This makes `PyJWT.decode` use the `verify_signature` option when calling `PyJWT.decode`, and therefore also allows to use `stacklevel=2` there then for the DeprecationWarning.
blueyed
added a commit
to blueyed/pyjwt
that referenced
this pull request
Jun 12, 2017
Followup to jpadilla#270: It seems that "verify" is only deprecated with `PyJWS.decode`, which makes sense, since you would have to override a lot of options to skip the verification in `PyJWT._validate_claims`. This makes `PyJWT.decode` use the `verify_signature` option when calling `PyJWT.decode`, and therefore also allows to use `stacklevel=2` there then for the DeprecationWarning.
blueyed
added a commit
to blueyed/pyjwt
that referenced
this pull request
Jun 21, 2017
Followup to jpadilla#270: It seems that "verify" is only deprecated with `PyJWS.decode`, which makes sense, since you would have to override a lot of options to skip the verification in `PyJWT._validate_claims`. This makes `PyJWT.decode` use the `verify_signature` option when calling `PyJWT.decode`, and therefore also allows to use `stacklevel=2` there then for the DeprecationWarning.
jpadilla
pushed a commit
that referenced
this pull request
Jun 21, 2017
Followup to #270: It seems that "verify" is only deprecated with `PyJWS.decode`, which makes sense, since you would have to override a lot of options to skip the verification in `PyJWT._validate_claims`. This makes `PyJWT.decode` use the `verify_signature` option when calling `PyJWT.decode`, and therefore also allows to use `stacklevel=2` there then for the DeprecationWarning.
rylanhall33
added a commit
to rylanhall33/pyjwt
that referenced
this pull request
Jun 15, 2022
Followup to jpadilla/pyjwt#270: It seems that "verify" is only deprecated with `PyJWS.decode`, which makes sense, since you would have to override a lot of options to skip the verification in `PyJWT._validate_claims`. This makes `PyJWT.decode` use the `verify_signature` option when calling `PyJWT.decode`, and therefore also allows to use `stacklevel=2` there then for the DeprecationWarning.
xmas7
pushed a commit
to RubyOnWorld/pyjwt
that referenced
this pull request
Sep 6, 2022
Followup to jpadilla/pyjwt#270: It seems that "verify" is only deprecated with `PyJWS.decode`, which makes sense, since you would have to override a lot of options to skip the verification in `PyJWT._validate_claims`. This makes `PyJWT.decode` use the `verify_signature` option when calling `PyJWT.decode`, and therefore also allows to use `stacklevel=2` there then for the DeprecationWarning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've thought about adding
stacklevel=2, but it is used internally / passed through, so that might not be that helpful.