Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add defaultThemeColor option #849

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

ItsSunnyMonster
Copy link
Contributor

Some applications (such as Discord) use the theme-color meta tag to display an accent color on its embeds. Currently the theme-color will be changed when the page loads by a script to reflect the current theme of the page (dark or light), but Discord ignores this and takes the value off of the original HTML. Therefore we can safely set this tag to some color specified by the user and not break the theme-aware theme-color functionality.

P.S. I don't speak Japanese so it will be great if anyone could translate the documentation for the new param.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 1, 2024
Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for hugo-congo ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4f65d3b
🔍 Latest deploy log https://app.netlify.com/sites/hugo-congo/deploys/660a5aaa4d374e0008fb168f
😎 Deploy Preview https://deploy-preview-849--hugo-congo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jpanther jpanther added the enhancement New feature or request label Apr 17, 2024
@jpanther
Copy link
Owner

Thanks for the PR, @ItsSunnyMonster. I'm happy to add this feature in, and the documentation you've supplied is super helpful! Will merge it in now.

@jpanther jpanther merged commit 2615943 into jpanther:dev Apr 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants