Add validation functions to autoscaling lifecycle hook arguments

Reference for validation patterns: https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_LifecycleHook.html

aws/resource_aws_autoscaling_lifecycle_hook.go

@@ -3,6 +3,7 @@ package aws
 import (
 	"fmt"
 	"log"
+	"regexp"
 	"strings"
 	"time"
 
@@ -11,6 +12,7 @@ import (
 	"github.com/aws/aws-sdk-go/service/autoscaling"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 )
 
 func resourceAwsAutoscalingLifecycleHook() *schema.Resource {
@@ -29,35 +31,45 @@ func resourceAwsAutoscalingLifecycleHook() *schema.Resource {
 				Type:     schema.TypeString,
 				Required: true,
 				ForceNew: true,
+				ValidateFunc: validation.All(
+					validation.StringLenBetween(1, 255),
+					validation.StringMatch(regexp.MustCompile(`[A-Za-z0-9\-_\/]+`),
+						`must satisfy regular expression pattern: [A-Za-z0-9\-_\/]+`),
+				),
 			},
 			"autoscaling_group_name": {
-				Type:     schema.TypeString,
-				Required: true,
+				Type:         schema.TypeString,
+				Required:     true,
+				ValidateFunc: validation.StringLenBetween(1, 1600),
 			},
 			"default_result": {
-				Type:     schema.TypeString,
-				Optional: true,
-				Computed: true,
+				Type:         schema.TypeString,
+				Optional:     true,
+				Computed:     true,
+				ValidateFunc: validation.StringInSlice([]string{"CONTINUE", "ABANDON"}, false),
 			},
 			"heartbeat_timeout": {
 				Type:     schema.TypeInt,
 				Optional: true,
 			},
 			"lifecycle_transition": {
-				Type:     schema.TypeString,
-				Required: true,
+				Type:         schema.TypeString,
+				Required:     true,
+				ValidateFunc: validation.StringInSlice([]string{"autoscaling:EC2_INSTANCE_LAUNCHING", "autoscaling:EC2_INSTANCE_TERMINATING"}, false),
 			},
 			"notification_metadata": {
 				Type:     schema.TypeString,
 				Optional: true,
 			},
 			"notification_target_arn": {
-				Type:     schema.TypeString,
-				Optional: true,
+				Type:         schema.TypeString,
+				Optional:     true,
+				ValidateFunc: validateArn,
 			},
 			"role_arn": {
-				Type:     schema.TypeString,
-				Optional: true,
+				Type:         schema.TypeString,
+				Optional:     true,
+				ValidateFunc: validateArn,
 			},
 		},
 	}