Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use rollup as build tool #153

Merged
merged 4 commits into from
Aug 4, 2022
Merged

Conversation

TrickyPi
Copy link
Collaborator

@TrickyPi TrickyPi commented Aug 1, 2022

closes #152.

also reduce the size of xhook.min.js to 8kb.

@TrickyPi TrickyPi requested a review from jpillora August 4, 2022 12:54
Copy link
Owner

@jpillora jpillora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@TrickyPi TrickyPi merged commit f19b530 into jpillora:main Aug 4, 2022
@TrickyPi TrickyPi deleted the feat/use-rollup branch August 4, 2022 13:31
@jpillora
Copy link
Owner

jpillora commented Aug 4, 2022

Feel free to release a new version, if we're confident its just the import fix - should probably be patch bump. Otherwise do a minor bump

@TrickyPi
Copy link
Collaborator Author

TrickyPi commented Aug 4, 2022

Ok, i will release a patched version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the output of xhook in src/main.js
2 participants