Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selective build #2202

Merged
merged 18 commits into from
Nov 17, 2022
Merged

Selective build #2202

merged 18 commits into from
Nov 17, 2022

Conversation

cristiano-belloni
Copy link
Contributor

@cristiano-belloni cristiano-belloni commented Nov 9, 2022 •
edited
Loading

Implement:

  • --changed
  • --compareBranch
  • --ancestors
  • --descendants

for modular build. See the updated documentation and tests for an in-depth description.

@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: d353a7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
modular-scripts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link
Collaborator

Coverage Status

Coverage decreased (-0.1%) to 33.499% when pulling bc1019d on feature/selective-build-changed into f79847a on main.

@coveralls
Copy link
Collaborator

coveralls commented Nov 9, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 33.313% when pulling d353a7b on feature/selective-build-changed into 644030d on main.

@cristiano-belloni cristiano-belloni changed the title Selective builds: changed packages Selective build Nov 15, 2022
@cristiano-belloni cristiano-belloni marked this pull request as ready for review November 16, 2022 14:19
@ayseenver
Copy link
Contributor

Are the packages a/b/c/d for testing? Do you want to commit them into main?

AlbertoBrusa
AlbertoBrusa reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@AlbertoBrusa AlbertoBrusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments just around general clarity/comments/docs, the code looks good :)

docs/commands/build.md Outdated Show resolved Hide resolved
packages/modular-scripts/src/program.ts Outdated Show resolved Hide resolved
packages/modular-scripts/src/test/utils.ts Outdated Show resolved Hide resolved
packages/modular-scripts/src/utils/getChangedWorkspaces.ts Outdated Show resolved Hide resolved
sgb-io
sgb-io previously approved these changes Nov 17, 2022
View reviewed changes
@cristiano-belloni cristiano-belloni merged commit d98802f into main Nov 17, 2022
@cristiano-belloni cristiano-belloni deleted the feature/selective-build-changed branch November 17, 2022 15:54
@github-actions github-actions bot mentioned this pull request Nov 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbertoBrusa AlbertoBrusa AlbertoBrusa approved these changes

@sgb-io sgb-io sgb-io approved these changes

@benpryke benpryke Awaiting requested review from benpryke

@steveukx steveukx Awaiting requested review from steveukx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cristiano-belloni @coveralls @ayseenver @sgb-io @AlbertoBrusa