-
Notifications
You must be signed in to change notification settings - Fork 775
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rewrite copy, add more tests to copy, activate skipped move test
- Loading branch information
Showing
34 changed files
with
953 additions
and
651 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
192 changes: 192 additions & 0 deletions
192
lib/copy/__tests__/copy-prevent-copying-identical.test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,192 @@ | ||
| 'use strict' | ||
|
|
||
| const assert = require('assert') | ||
| const os = require('os') | ||
| const path = require('path') | ||
| const fs = require(process.cwd()) | ||
| const klawSync = require('klaw-sync') | ||
|
|
||
| /* global beforeEach, afterEach, describe, it */ | ||
|
|
||
| describe('+ copySync() - prevent copying identical files and dirs', () => { | ||
| let TEST_DIR = '' | ||
| let src = '' | ||
| let dest = '' | ||
|
|
||
| beforeEach(done => { | ||
| TEST_DIR = path.join(os.tmpdir(), 'fs-extra', 'copy-sync-prevent-copying-identical') | ||
| fs.emptyDir(TEST_DIR, done) | ||
| }) | ||
|
|
||
| afterEach(done => fs.remove(TEST_DIR, done)) | ||
|
|
||
| it('should return an error if src and dest are the same', done => { | ||
| const fileSrc = path.join(TEST_DIR, 'TEST_fs-extra_copy_sync') | ||
| const fileDest = path.join(TEST_DIR, 'TEST_fs-extra_copy_sync') | ||
|
|
||
| fs.copy(fileSrc, fileDest, err => { | ||
| assert.equal(err.message, 'Source and destination must not be the same.') | ||
| done() | ||
| }) | ||
| }) | ||
|
|
||
| // src is directory: | ||
| // src is regular, dest is symlink | ||
| // src is symlink, dest is regular | ||
| // src is symlink, dest is symlink | ||
|
|
||
| describe('> when the source is a directory', () => { | ||
| describe(`>> when src is regular and dest is a symlink that points to src`, () => { | ||
| it('should not copy and return', done => { | ||
| src = path.join(TEST_DIR, 'src') | ||
| fs.mkdirsSync(src) | ||
| const subdir = path.join(TEST_DIR, 'src', 'subdir') | ||
| fs.mkdirsSync(subdir) | ||
| fs.writeFileSync(path.join(subdir, 'file.txt'), 'some data') | ||
|
|
||
| const destLink = path.join(TEST_DIR, 'dest-symlink') | ||
| fs.symlinkSync(src, destLink, 'dir') | ||
|
|
||
| const oldlen = klawSync(src).length | ||
|
|
||
| fs.copy(src, destLink, err => { | ||
| assert.ifError(err) | ||
|
|
||
| const newlen = klawSync(src).length | ||
| assert.strictEqual(newlen, oldlen) | ||
| const link = fs.readlinkSync(destLink) | ||
| assert.strictEqual(link, src) | ||
| done() | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| describe(`>> when src is a symlink that points to a regular dest`, () => { | ||
| it('should not copy and return', done => { | ||
| dest = path.join(TEST_DIR, 'dest') | ||
| fs.mkdirsSync(dest) | ||
| const subdir = path.join(TEST_DIR, 'dest', 'subdir') | ||
| fs.mkdirsSync(subdir) | ||
| fs.writeFileSync(path.join(subdir, 'file.txt'), 'some data') | ||
|
|
||
| const srcLink = path.join(TEST_DIR, 'src-symlink') | ||
| fs.symlinkSync(dest, srcLink, 'dir') | ||
|
|
||
| const oldlen = klawSync(dest).length | ||
|
|
||
| fs.copy(srcLink, dest, err => { | ||
| assert.ifError(err) | ||
|
|
||
| // assert nothing copied | ||
| const newlen = klawSync(dest).length | ||
| assert.strictEqual(newlen, oldlen) | ||
| const link = fs.readlinkSync(srcLink) | ||
| assert.strictEqual(link, dest) | ||
| done() | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| describe('>> when src and dest are symlinks that point to the exact same path', () => { | ||
| it('should not copy and return', done => { | ||
| src = path.join(TEST_DIR, 'src') | ||
| fs.mkdirsSync(src) | ||
| const srcLink = path.join(TEST_DIR, 'src_symlink') | ||
| fs.symlinkSync(src, srcLink, 'dir') | ||
| const destLink = path.join(TEST_DIR, 'dest_symlink') | ||
| fs.symlinkSync(src, destLink, 'dir') | ||
|
|
||
| const srclenBefore = klawSync(srcLink).length | ||
| const destlenBefore = klawSync(destLink).length | ||
|
|
||
| fs.copy(srcLink, destLink, err => { | ||
| assert.ifError(err) | ||
|
|
||
| const srclenAfter = klawSync(srcLink).length | ||
| assert.strictEqual(srclenAfter, srclenBefore, 'src length should not change') | ||
| const destlenAfter = klawSync(destLink).length | ||
| assert.strictEqual(destlenAfter, destlenBefore, 'dest length should not change') | ||
|
|
||
| const srcln = fs.readlinkSync(srcLink) | ||
| assert.strictEqual(srcln, src) | ||
| const destln = fs.readlinkSync(destLink) | ||
| assert.strictEqual(destln, src) | ||
| done() | ||
| }) | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| // src is file: | ||
| // src is regular, dest is symlink | ||
| // src is symlink, dest is regular | ||
| // src is symlink, dest is symlink | ||
|
|
||
| describe('> when the source is a file', () => { | ||
| describe(`>> when src is regular and dest is a symlink that points to src`, () => { | ||
| it('should not copy and return', done => { | ||
| src = path.join(TEST_DIR, 'src', 'somefile.txt') | ||
| fs.ensureFileSync(src) | ||
| fs.writeFileSync(src, 'some data') | ||
|
|
||
| const destLink = path.join(TEST_DIR, 'dest-symlink') | ||
| fs.symlinkSync(src, destLink, 'file') | ||
|
|
||
| fs.copy(src, destLink, err => { | ||
| assert.ifError(err) | ||
|
|
||
| const link = fs.readlinkSync(destLink) | ||
| assert.strictEqual(link, src) | ||
| assert(fs.readFileSync(link, 'utf8'), 'some data') | ||
| done() | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| describe(`>> when src is a symlink that points to a regular dest`, () => { | ||
| it('should not copy and return', done => { | ||
| dest = path.join(TEST_DIR, 'dest', 'somefile.txt') | ||
| fs.ensureFileSync(dest) | ||
| fs.writeFileSync(dest, 'some data') | ||
|
|
||
| const srcLink = path.join(TEST_DIR, 'src-symlink') | ||
| fs.symlinkSync(dest, srcLink, 'file') | ||
|
|
||
| fs.copy(srcLink, dest, err => { | ||
| assert.ifError(err) | ||
|
|
||
| const link = fs.readlinkSync(srcLink) | ||
| assert.strictEqual(link, dest) | ||
| assert(fs.readFileSync(link, 'utf8'), 'some data') | ||
| done() | ||
| }) | ||
| }) | ||
| }) | ||
|
|
||
| describe('>> when src and dest are symlinks that point to the exact same path', () => { | ||
| it('should not copy and return', done => { | ||
| src = path.join(TEST_DIR, 'src', 'srcfile.txt') | ||
| fs.ensureFileSync(src) | ||
| fs.writeFileSync(src, 'src data') | ||
|
|
||
| const srcLink = path.join(TEST_DIR, 'src_symlink') | ||
| fs.symlinkSync(src, srcLink, 'file') | ||
|
|
||
| const destLink = path.join(TEST_DIR, 'dest_symlink') | ||
| fs.symlinkSync(src, destLink, 'file') | ||
|
|
||
| fs.copy(srcLink, destLink, err => { | ||
| assert.ifError(err) | ||
|
|
||
| const srcln = fs.readlinkSync(srcLink) | ||
| assert.strictEqual(srcln, src) | ||
| const destln = fs.readlinkSync(destLink) | ||
| assert.strictEqual(destln, src) | ||
| assert(fs.readFileSync(srcln, 'utf8'), 'src data') | ||
| assert(fs.readFileSync(destln, 'utf8'), 'src data') | ||
| done() | ||
| }) | ||
| }) | ||
| }) | ||
| }) | ||
| }) |
Oops, something went wrong.