Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use writeStream 'finish' event instead of 'close' #327

Merged
merged 1 commit into from
Dec 26, 2016
Merged

Use writeStream 'finish' event instead of 'close' #327

merged 1 commit into from
Dec 26, 2016

Conversation

nicks
Copy link
Contributor

@nicks nicks commented Dec 20, 2016

Fixes #326

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.407% when pulling 25a88e1 on Medium:nicks/close into 8b15acb on jprichardson:1.x.

@RyanZim RyanZim changed the base branch from 1.x to master December 21, 2016 00:54
RyanZim
RyanZim requested changes Dec 21, 2016
View reviewed changes
Copy link
Collaborator

@RyanZim RyanZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, just noticed this PR is against the wrong branch. @nicks Can you rebase this onto master?

@nicks
Copy link
Contributor Author

nicks commented Dec 21, 2016

oops sorry! ya it should be better now.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.424% when pulling 543112b on Medium:nicks/close into 5f319b6 on jprichardson:master.

@RyanZim RyanZim added this to the 2.0.0 milestone Dec 24, 2016
@jprichardson jprichardson merged commit 0527b39 into jprichardson:master Dec 26, 2016
@RyanZim RyanZim mentioned this pull request Dec 26, 2016
Closed
@RyanZim RyanZim mentioned this pull request Feb 21, 2017
Closed
@jprichardson jprichardson mentioned this pull request Feb 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanZim RyanZim RyanZim approved these changes

@jprichardson jprichardson Awaiting requested review from jprichardson

Assignees
No one assigned
Labels
bug feature-copy
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nicks @coveralls @RyanZim @jprichardson