Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native fs.copyFile and fs.copyFileSync to copy() and copySync() #505

Merged
merged 2 commits into from
Nov 7, 2017

Conversation

manidlou
Copy link
Collaborator

@manidlou manidlou commented Oct 31, 2017

Ref: #490.

This is based against the develop branch.

Added native fs.copyFile and fs.copyFileSync to copy() and copySync().

@manidlou
Copy link
Collaborator Author

IDK what the problem is with travis! @jprichardson @RyanZim do you know what the issue is with travis?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 86.961% when pulling 0bd5279 on native-copyFile into 166f4a7 on develop.

@RyanZim
Copy link
Collaborator

RyanZim commented Oct 31, 2017

Restarted the build and it worked!

Copy link
Collaborator

@RyanZim RyanZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; tested locally on Node 8 and ensured that the native method is indeed being used in environments that support it without issues.

@manidlou manidlou changed the title Add native fs.copyFile to copy() Add native fs.copyFile* to copy*() Nov 1, 2017
@manidlou manidlou changed the title Add native fs.copyFile* to copy*() Add native fs.copyFile and fs.copyFileSync to copy() and copySync() Nov 1, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 85.828% when pulling 1abc2a3 on native-copyFile into 166f4a7 on develop.

@manidlou
Copy link
Collaborator Author

manidlou commented Nov 6, 2017

@jprichardson ping?!

@jprichardson
Copy link
Owner

Looks good. Should be bundled in next major along with copy() changes.

@jprichardson jprichardson merged commit d8adc47 into develop Nov 7, 2017
@jprichardson jprichardson deleted the native-copyFile branch November 7, 2017 17:52
@RyanZim RyanZim added this to the 5.0.0 milestone Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants