Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use files array in package.json instead of .npmignore #692

Merged
merged 1 commit into from
May 23, 2019
Merged

Use files array in package.json instead of .npmignore #692

merged 1 commit into from
May 23, 2019

Conversation

RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented May 22, 2019

Whitelists are better than blacklists. Tested to ensure the same files are bundled with npm pack.

@RyanZim
Use files array in package.json instead of .npmignore
98aa6a1 
Whitelists are better than blacklists. Tested to ensure the same files
are bundled with `npm pack`.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.835% when pulling 98aa6a1 on ryan/files into 7a8424e on master.

@RyanZim RyanZim merged commit fff04cb into master May 23, 2019
@RyanZim RyanZim deleted the ryan/files branch May 23, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manidlou manidlou manidlou approved these changes

@JPeer264 JPeer264 JPeer264 approved these changes

@jprichardson jprichardson Awaiting requested review from jprichardson

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RyanZim @coveralls @JPeer264 @manidlou