Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml-request command #315

Merged
merged 2 commits into from
Dec 13, 2016
Merged

Add yaml-request command #315

merged 2 commits into from
Dec 13, 2016

Conversation

keith
Copy link
Contributor

@keith keith commented Dec 12, 2016

This command allows you to pass a yaml file that defines a sourcekit
request to be executed.

Fixes #312

@jpsim
Copy link
Owner

jpsim commented Dec 12, 2016

I'm wondering if it'd be a bit more future-proof to name this sourcekitten request --yaml [file or yaml string], in case we want to support passing request info in other formats moving forward (such as --json).

@keith
Copy link
Contributor Author

keith commented Dec 12, 2016

Updated

This command allows you to pass a yaml file or text that defines a
sourcekit request to be executed.
@keith
Copy link
Contributor Author

keith commented Dec 12, 2016

Added changelog and readme entries

and reference addressed issue rather than PR
@jpsim
Copy link
Owner

jpsim commented Dec 12, 2016

🎉 fantastic! Will merge once CI agrees.

@keith
Copy link
Contributor Author

keith commented Dec 12, 2016

Awesome thanks!

@keith
Copy link
Contributor Author

keith commented Dec 13, 2016

If you want you could probably cancel some travis jobs. A few got started very quickly when I pushed changelog and readme updates https://travis-ci.org/jpsim/SourceKitten/pull_requests

@jpsim jpsim merged commit 4ea9c92 into jpsim:master Dec 13, 2016
@keith keith deleted the ks/yaml-cmd branch December 13, 2016 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants