Fix the trimming of trailing characters. #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the string ended with extended grapheme clusters, the method crashed because of the force-unwrapping. This refactoring adds support for handling extended grapheme clusters.
Lukas-Stuehrk
force-pushed
the
fixStringTrimming
branch
from
2277680
to
ef49d43
Compare
norio-nomura
requested changes
Mar 29, 2017
| var string = self.bridge() | ||
| let endIndex = string.unicodeScalars.endIndex | ||
| for offset in 1...string.unicodeScalars.count { | ||
| let index = string.unicodeScalars.index(endIndex, offsetBy: -offset) |
There was a problem hiding this comment.
This creates the index from the end of the string every time.
Can you reuse the index created in the previous loop to reduce computational cost?
There was a problem hiding this comment.
Yes, you're right. Thanks for the input. I think there's even a much easier implementation (at least for me it's much easier to wrap my head around 😉 ):
var unicodeScalars = self.bridge().unicodeScalars
while let scalar = unicodeScalars.last {
if !characterSet.contains(scalar) {
return String(unicodeScalars)
}
unicodeScalars.removeLast()
}Do you have concerns?
norio-nomura
approved these changes
Mar 30, 2017
|
Could you please add a changelog entry? Thanks! |
|
Sure! Done. |
|
Thanks @Lukas-Stuehrk! |
|
You're welcome. I'm happy to help on such a handy and important piece in the Swift tooling. Thanks for the fast reviews, good feedback and all your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the string ended with extended grapheme clusters, the method
crashed because of the force-unwrapping. This refactoring adds support
for handling extended grapheme clusters.
This fixes #350