Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use Argument instead of Option on IndexCommand.Options.compilerargs #481

Merged
merged 1 commit into from
Mar 7, 2018

Conversation

norio-nomura
Copy link
Collaborator

Fix #480

@norio-nomura
Copy link
Collaborator Author

That is caused by illegal handling of spaces in compiler arguments.

$ echo 'print("space hello")'>space\ hello.swift
$ SOURCEKIT_LOGGING=1 sourcekitten index --file "space hello.swift" --compilerargs -- "`pwd`/space hello.swift"
sourcekit: [2:sourcekitd_initialize:4363: 0.0000] initializing
sourcekit: [2:sourcekitd_send_request_sync-before:4363: 0.0008] {
  key.request: source.request.indexsource,
  key.compilerargs: [
    "/Users/norio/github/swift-dev/SourceKitten/space",
    "hello.swift"
  ],
  key.sourcefile: "/Users/norio/github/swift-dev/SourceKitten/space hello.swift"
}
sourcekit: [2:sourcekitd_send_request_sync-after:4363: 0.0476] 
[1]    84434 illegal hardware instruction  SOURCEKIT_LOGGING=1 sourcekitten index --file "space hello.swift"  -- 

@jpsim
Copy link
Owner

jpsim commented Mar 7, 2018

Thanks for the fix!

@jpsim jpsim merged commit 914b7ce into master Mar 7, 2018
@jpsim jpsim deleted the nn-fix-480 branch March 7, 2018 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants