Fix misidentification of .swift-suffixed directory as a Swift file

[1ec5]

A “.swift”-suffixed directory in xcodebuild arguments is no longer detected as a Swift file.

Fixes #574.

[jpsim]

This fix looks correct, I have to look into why it's failing tests on CI.

[jpsim]

Suggested changes:

diff --git a/Source/SourceKittenFramework/String+SourceKitten.swift b/Source/SourceKittenFramework/String+SourceKitten.swift
index f12a316..05e57cf 100644
--- a/Source/SourceKittenFramework/String+SourceKitten.swift
+++ b/Source/SourceKittenFramework/String+SourceKitten.swift
@@ -465,10 +465,6 @@ extension NSString {
 }
 
 extension String {
-    internal var isFileOrDirectory: Bool {
-        return FileManager.default.fileExists(atPath: self)
-    }
-
     internal var isFile: Bool {
         var isDirectory: ObjCBool = false
         let exists = FileManager.default.fileExists(atPath: self, isDirectory: &isDirectory)
diff --git a/Source/SourceKittenFramework/library_wrapper.swift b/Source/SourceKittenFramework/library_wrapper.swift
index 335130e..0651afe 100644
--- a/Source/SourceKittenFramework/library_wrapper.swift
+++ b/Source/SourceKittenFramework/library_wrapper.swift
@@ -42,7 +42,7 @@ let toolchainLoader = Loader(searchPaths: [
     userApplicationsDir?.xcodeDeveloperDir.toolchainDir,
     userApplicationsDir?.xcodeBetaDeveloperDir.toolchainDir
 ].compactMap { path in
-    if let fullPath = path?.usrLibDir, fullPath.isFile {
+    if let fullPath = path?.usrLibDir, FileManager.default.fileExists(atPath: fullPath) {
         return fullPath
     }
     return nil
@@ -53,7 +53,7 @@ struct Loader {
     let searchPaths: [String]
 
     func load(path: String) -> DynamicLinkLibrary {
-        let fullPaths = searchPaths.map { $0.appending(pathComponent: path) }.filter { $0.isFileOrDirectory }
+        let fullPaths = searchPaths.map { $0.appending(pathComponent: path) }.filter { $0.isFile }
 
         // try all fullPaths that contains target file,
         // then try loading with simple path that depends resolving to DYLD

[jpsim]

Thanks!