Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build universal2 wheels for macos #130

Merged

Conversation

devinrsmith
Copy link
Member

This ensures that python 3.8+ produce universal2 wheels (python 3.6, 3.7 doesn't support M1).

Fixes #110

This ensures that python 3.8+ produce universal2 wheels (python 3.6, 3.7 doesn't support M1).

Fixes jpy-consortium#110
@devinrsmith devinrsmith self-assigned this Jan 11, 2024
@devinrsmith
Copy link
Member Author

Here are the resulting macos wheels:

jpy-0.16.0.dev0-cp36-cp36m-macosx_10_14_x86_64.whl
jpy-0.16.0.dev0-cp37-cp37m-macosx_11_0_x86_64.whl
jpy-0.16.0.dev0-cp38-cp38-macosx_11_0_universal2.whl
jpy-0.16.0.dev0-cp39-cp39-macosx_11_0_universal2.whl
jpy-0.16.0.dev0-cp310-cp310-macosx_11_0_universal2.whl
jpy-0.16.0.dev0-cp311-cp311-macosx_10_9_universal2.whl
jpy-0.16.0.dev0-cp312-cp312-macosx_10_9_universal2.whl

I've done basic smoketest that all of the universal2 wheels work on an M1.

Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devinrsmith devinrsmith merged commit 00a61c4 into jpy-consortium:master Jan 12, 2024
27 checks passed
@devinrsmith devinrsmith deleted the add-universal2-builds branch January 12, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Produce M1-compatible wheels in CI
2 participants