Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The keyword label can't be used as a binding name :( #2675

Closed
nicowilliams opened this issue Jul 9, 2023 · 1 comment · Fixed by #2681
Closed

The keyword label can't be used as a binding name :( #2675

nicowilliams opened this issue Jul 9, 2023 · 1 comment · Fixed by #2681

Comments

@nicowilliams
Copy link
Contributor 

jq -n '. as $label | $label'
jq: error: syntax error, unexpected label, expecting IDENT (Unix shell quoting issues?) at <top-level>, line 1:
. as $label | $label
jq: 1 compile error

We should make sure all keywords can be used as $keyword bindings.
@emanuele6
Copy link
Member

It is also possible to use $ var or reduce range(10) as $ foo (.

Since we want to allow $label, and, in the parser, '$' is always used as '$' IDENT, we could just disallow $ foo, and lex those directly as VARIABLE tokens:

"$"[a-zA-Z_][a-zA-Z_0-9]*  { yylval->literal = jv_string(yytext + 1); return VARIABLE;}

Then we should just need to replace all '$' IDENT in the parser with VARIABLE.

emanuele6 added a commit to emanuele6/jq-1 that referenced this issue Jul 9, 2023
@emanuele6
Lex $foo as a single token, instead of using '$' IDENT
92e1a97 
Previously, variable/symbols were parsed as the combination of two
tokens: '$' IDENT

This meant that using a keyword as variable name (e.g. $then, $label)
did not work.
Attempts were made to allow $keyword to work by adding some '$' Keyword
rules in the parser, but this did not allow $keyword in all places:

  jq --arg label foo -n '$label'  # ok

  jq -n '"foo" as $label | .'     # error

Treating $foo as a single token is much simpler, in my opinion.

This patch also changes how LOC is lexed: "$__loc__" instead of as
"__loc__" that gets combined with '$' in the parser.

This patch also disallows having spaces after '$' when recalling a
variable  `$ foo'  since that was probably just an unintentional side
effect of the implementation, and it was not documented.

Fixes jqlang#2675
emanuele6 added a commit to emanuele6/jq-1 that referenced this issue Jul 9, 2023
@emanuele6
Lex $foo as a single token, instead of using '$' IDENT
3426d32 
Previously, variable/symbols were parsed as the combination of two
tokens: '$' IDENT

This meant that using a keyword as variable name (e.g. $then, $label)
did not work.
Attempts were made to allow $keyword to work by adding some '$' Keyword
rules in the parser, but this did not allow $keyword in all places:

  jq --arg label foo -n '$label'  # ok

  jq -n '"foo" as $label | .'     # error

Treating $foo as a single token is much simpler, in my opinion.

This patch also changes how LOC is lexed: "$__loc__" instead of as
"__loc__" that gets combined with '$' in the parser.

This patch also disallows having spaces after '$' when recalling a
variable  `$ foo'  since that was probably just an unintentional side
effect of the implementation, and it was not documented.

Fixes jqlang#2675
@emanuele6 emanuele6 mentioned this issue Jul 9, 2023
Merged
emanuele6 added a commit to emanuele6/jq-1 that referenced this issue Jul 9, 2023
@emanuele6
Lex $foo as a single token, instead of using '$' IDENT
1dd9597 
Previously, variable/symbols were parsed as the combination of two
tokens: '$' IDENT

This meant that using a keyword as variable name (e.g. $then, $label)
did not work.
Attempts were made to allow $keyword to work by adding some '$' Keyword
rules in the parser, but this did not allow $keyword in all places:

  jq --arg label foo -n '$label'  # ok

  jq -n '"foo" as $label | .'     # error

Treating $foo as a single token is much simpler, in my opinion.

This patch also changes how LOC is lexed: "$__loc__" instead of as
"__loc__" that gets combined with '$' in the parser.

This patch also disallows having spaces after '$' when recalling a
variable  `$ foo'  since that was probably just an unintentional side
effect of the implementation, and it was not documented.

Fixes jqlang#2675
emanuele6 added a commit to emanuele6/jq-1 that referenced this issue Jul 9, 2023
@emanuele6
Lex $foo as a single token, instead of using '$' IDENT
36a7f83 
Previously, bindings were parsed as the combination of two tokens:
  '$' IDENT

This meant that using a keyword as variable name (e.g. $then, $label)
did not work.
Attempts were made to allow $keyword to work by adding some '$' Keyword
rules in the parser, but this did not allow $keyword in all places:

  jq --arg label foo -n '$label'  # ok

  jq -n '"foo" as $label | .'     # error

Treating $foo as a single token is much simpler, in my opinion.

This patch also changes how LOC is lexed: "$__loc__" instead of as
"__loc__" that gets combined with '$' in the parser.

This patch also disallows having spaces after '$' when recalling a
variable  `$ foo'  since that was probably just an unintentional side
effect of the implementation, and it was not documented.

Fixes jqlang#2675
emanuele6 added a commit to emanuele6/jq-1 that referenced this issue Jul 9, 2023
@emanuele6
Lex $foo as a single token, instead of using '$' IDENT
996ab54 
Previously, bindings were parsed as the combination of two tokens:
  '$' IDENT

This meant that using a keyword as variable name (e.g. $then, $label)
did not work.
Attempts were made to allow $keyword to work by adding some '$' Keyword
rules in the parser, but this did not allow $keyword in all places:

  jq --arg label foo -n '$label'  # ok

  jq -n '"foo" as $label | .'     # error

Treating $foo as a single token is much simpler, in my opinion.

This patch also changes how LOC is lexed: "$__loc__" instead of as
"__loc__" that gets combined with '$' in the parser.

This patch also disallows having spaces after '$' when recalling a
variable  `$ foo'  since that was probably just an unintentional side
effect of the implementation, and it was not documented.

Fixes jqlang#2675
emanuele6 added a commit to emanuele6/jq-1 that referenced this issue Jul 9, 2023
@emanuele6
Lex $foo as a single token, instead of using '$' IDENT
4c139f8 
Previously, bindings were parsed as the combination of two tokens:
  '$' IDENT

This meant that using a keyword as variable name (e.g. $then, $label)
did not work.
Attempts were made to allow $keyword to work by adding some '$' Keyword
rules in the parser, but this did not allow $keyword in all places:

  jq --arg label foo -n '$label'  # ok

  jq -n '"foo" as $label | .'     # error

Treating $foo as a single token is much simpler, in my opinion.

This patch also changes how LOC is lexed: "$__loc__" instead of as
"__loc__" that gets combined with '$' in the parser.

This patch also disallows having spaces after '$' when recalling a
variable  `$ foo'  since that was probably just an unintentional side
effect of the implementation, and it was not documented.

Fixes jqlang#2675
emanuele6 added a commit to emanuele6/jq-1 that referenced this issue Jul 9, 2023
@emanuele6
Lex $foo as a single token, instead of using '$' IDENT
2a7b623 
Previously, bindings were parsed as the combination of two tokens:
  '$' IDENT

This meant that using a keyword as variable name (e.g. $then, $label)
did not work.
Attempts were made to allow $keyword to work by adding some '$' Keyword
rules in the parser, but this did not allow $keyword in all places:

  jq --arg label foo -n '$label'  # ok

  jq -n '"foo" as $label | .'     # error

Treating $foo as a single token is much simpler, in my opinion.

This patch also changes how LOC is lexed: "$__loc__" instead of as
"__loc__" that gets combined with '$' in the parser.

This patch also disallows having spaces after '$' when recalling a
variable  `$ foo'  since that was probably just an unintentional side
effect of the implementation, and it was not documented.

Fixes jqlang#2675
emanuele6 added a commit to emanuele6/jq-1 that referenced this issue Jul 9, 2023
@emanuele6
Lex $foo as a single token, instead of using '$' IDENT
5530049 
Previously, bindings were parsed as the combination of two tokens:
  '$' IDENT

This meant that using a keyword as variable name (e.g. $then, $label)
did not work.
Attempts were made to allow $keyword to work by adding some '$' Keyword
rules in the parser, but this did not allow $keyword in all places:

  jq --arg label foo -n '$label'  # ok

  jq -n '"foo" as $label | .'     # error

Treating $foo as a single token is much simpler, in my opinion.

This patch also changes how LOC is lexed: "$__loc__" instead of as
"__loc__" that gets combined with '$' in the parser.

This patch also disallows having spaces after '$' when recalling a
variable  `$ foo'  since that was probably just an unintentional side
effect of the implementation, and it was not documented.

Fixes jqlang#2675
nicowilliams pushed a commit that referenced this issue Jul 9, 2023
@emanuele6 @nicowilliams
Lex $foo as a single token, instead of using '$' IDENT
193f432 
Previously, bindings were parsed as the combination of two tokens:
  '$' IDENT

This meant that using a keyword as variable name (e.g. $then, $label)
did not work.
Attempts were made to allow $keyword to work by adding some '$' Keyword
rules in the parser, but this did not allow $keyword in all places:

  jq --arg label foo -n '$label'  # ok

  jq -n '"foo" as $label | .'     # error

Treating $foo as a single token is much simpler, in my opinion.

This patch also changes how LOC is lexed: "$__loc__" instead of as
"__loc__" that gets combined with '$' in the parser.

This patch also disallows having spaces after '$' when recalling a
variable  `$ foo'  since that was probably just an unintentional side
effect of the implementation, and it was not documented.

Fixes #2675
@emanuele6 emanuele6 mentioned this issue Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lex $foo as a single token, instead of using '$' IDENT emanuele6/jq-1
2 participants
@nicowilliams @emanuele6