Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile cleanup #845

Closed
dtolnay opened this issue Jul 10, 2015 · 3 comments · Fixed by #2649
Closed

Dockerfile cleanup #845

dtolnay opened this issue Jul 10, 2015 · 3 comments · Fixed by #2649
Labels
docker
Milestone
1.7 release

Comments

@dtolnay
Copy link
Member

dtolnay commented Jul 10, 2015

Following up on #842:

  • split into layers on natural boundaries (get dependencies, get code, build code and manual) to reduce rebuilding time
  • factor long steps into shell scripts, maybe even reusable in .travis.yml
  • enable valgrind if possible
@dtolnay dtolnay mentioned this issue Jul 10, 2015
Closed
@nicowilliams
Copy link
Contributor

Can Travis-CI build a dockerfile?

@dtolnay
Copy link
Member Author

dtolnay commented Jul 10, 2015

Good idea. I will give it a shot tonight.

@dtolnay
Copy link
Member Author

dtolnay commented Jul 11, 2015

As far as I can tell, no, not on the container-based Travis infrastructure:

It's not currently possible, mostly for security reasons, but is something we want to address in the future.

But Docker Hub can! https://docs.docker.com/docker-hub/builds/

@dtolnay dtolnay added the build label Jul 25, 2015
@itchyny itchyny added docker and removed build labels Jun 4, 2023
@itchyny itchyny mentioned this issue Jul 3, 2023
Merged
@itchyny itchyny added this to the 1.7 release milestone Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docker
Projects
None yet
Milestone
1.7 release
Development

Successfully merging a pull request may close this issue.

Improve Dockerfile: update base image and optimize image size itchyny/jq
3 participants
@itchyny @nicowilliams @dtolnay