Improve Dockerfile: update base image and optimize image size #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wader
reviewed
Jul 3, 2023
Dockerfile
Outdated
| RUN autoreconf -i \ | ||
| && ./configure \ | ||
| --disable-dependency-tracking \ | ||
| --disable-silent-rules \ |
There was a problem hiding this comment.
Got a curious about these options, seems --disable-silent-rules is the default? if so maybe can skip specify it? --disable-dependency-tracking seems to speed up one-time builds by not generate make dependency files, i suspect not much build speed up for jq?
There was a problem hiding this comment.
I agree. I'll drop both flags.
wader
reviewed
Jul 3, 2023
| rm -rf /app/modules/oniguruma/.git && \ | ||
| rm -rf /app/modules/oniguruma/.gitignore && \ | ||
| rm -rf /var/lib/apt/lists/* /var/lib/gems | ||
| FROM scratch |
There was a problem hiding this comment.
In dockerfiles like this i usually have a RUN ["/path/to/binary", "--version"] just as a sanity test that the binary can run correct in a scratch container, have saved me a couple of times
wader
reviewed
Jul 3, 2023
Dockerfile
Outdated
| CMD [] | ||
| COPY --from=builder /app/AUTHORS /app/COPYING /usr/local/bin/jq / | ||
| ENTRYPOINT ["/jq"] | ||
| CMD ["--help"] |
There was a problem hiding this comment.
Maybe skip or leave empty to make it behave as normal cli?
itchyny
force-pushed
the
improve-dockerfile
branch
from
c288a96
to
b5dbff5
Compare
wader
approved these changes
Jul 4, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves Dockerfile to resolve endless reports about the Docker image in the next release. I update the base image to Debian 12, and use multi-stage build to optimize the image size. We stop re-building the parser/lexer codes since that's what we do on building the release executables. We no longer re-build docs and manpage in this image, so drop dependency on Python. Releasing multi-arch image to GHCR will be in the next PR.
This PR closes #845, closes #1631, closes #1900, closes #2004, and closes #2617.