Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments in generated example have error #166

Open
justin808 opened this issue Apr 3, 2014 · 1 comment
Open

Comments in generated example have error #166

justin808 opened this issue Apr 3, 2014 · 1 comment

Comments

@justin808
Copy link

Default config file should not have dash in comments after config:, as that implies a list, whereas the value should be a hash. I can submit a PR if that helps, but maybe too minor. Any way, I had deleted the examples, and then when I followed the comments, I got an error, so this is worth fixing. Also worth adding the bit about heroku_accounts and the repo option to the README.md.

#
# Format:
#
# <stage name>:
#   app: <Heroku app name>
#   stack: <Heroku stack, optional>
#   tag: <git tag pattern, optional>
#   repo: <git repository, optional>
#   config:
#     - <Heroku config:var name>: <Heroku config:var value>
#

production:
  app: awesomeapp
  stack: bamboo-ree-1.8.7
  tag: production/*
  config:
    BUNDLE_WITHOUT: "development:test"
    GOOGLE_ANALYTICS: "UA-12345678-1"

staging:
  stack: cedar
  app: awesomeapp-staging
  config: &default
    BUNDLE_WITHOUT: "development:test"
  addons:
    - pgbackups:auto-week
    - memcache:5mb
    - logging:basic
    - scheduler:standard

demo:
  app: awesomeapp-demo
  config: *default
@kmayer
Copy link
Contributor

kmayer commented Apr 4, 2014

No PR is too minor! Please!

On Thu, Apr 3, 2014 at 3:33 PM, Justin Gordon [email protected]:

Default config file should not have dash in comments after config:, as
that implies a list, whereas the value should be a hash. I can submit a PR
if that helps, but maybe too minor. Any way, I had deleted the examples,
and then when I followed the comments, I got an error, so this is worth
fixing. Also worth adding the bit about heroku_accounts and the repo option
to the README.md.

Format:## :# app: # stack: <Heroku stack, optional># tag: <git tag pattern, optional># repo: <git repository, optional># config:# - :

production:
app: awesomeapp
stack: bamboo-ree-1.8.7
tag: production/*
config:
BUNDLE_WITHOUT: "development:test"
GOOGLE_ANALYTICS: "UA-12345678-1"
staging:
stack: cedar
app: awesomeapp-staging
config: &default
BUNDLE_WITHOUT: "development:test"
addons:
- pgbackups:auto-week
- memcache:5mb
- logging:basic
- scheduler:standard
demo:
app: awesomeapp-demo
config: *default

Reply to this email directly or view it on GitHubhttps://github.com//issues/166
.

[email protected] | (808) 722-6142 (c)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants