Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.11 wheels include typing info #101

Closed
vfazio opened this issue Nov 21, 2023 · 4 comments
Closed

0.2.11 wheels include typing info #101

vfazio opened this issue Nov 21, 2023 · 4 comments

Comments

@vfazio
Copy link

vfazio commented Nov 21, 2023

While I actually appreciate this because I use typing and it allows me to drop a #type: ignore marker when importing the package, based on #71 not being merged, I assume they actually shouldn't be there.

The sdist does not have typing info leading me to think the wheel may have been created on a different branch?

Also, the wheel looks to have a spurious .DS_Store file, similar to what's mentioned here: pypa/wheel#297

I haven't checked the CI yet, so i don't know if you're doing sdist/wheel builds and uploads there, my guess is no, but maybe they can be triggered on tags.

@GalaxySnail
Copy link
Collaborator

I haven't checked the CI yet, so i don't know if you're doing sdist/wheel builds and uploads there, my guess is no, but maybe they can be triggered on tags.

You are right. Currently CI is only used for testing, sdists and wheels are built and uploaded by @jquast.

@jquast
Copy link
Owner

jquast commented Nov 21, 2023

Sorry about that, I'll bump and make another release without it, I will be sure to git clean in release process, I've included a few .DS_Store's in past releases too, embarrassing !

@jquast
Copy link
Owner

jquast commented Nov 21, 2023

0.2.12 released, thanks!

@jquast jquast closed this as completed Nov 21, 2023
@jquast
Copy link
Owner

jquast commented Nov 21, 2023

I record my terminal sessions for important stuff like this and checked it for this release, it did get included in the distribution erroneously during my session, but I was on the master branch at the time it was built and it did not appear in output of git status.

I should have also executed git clean before package and will in the future. I'm also OK with allowing anyone who can tag the master branch to trigger an automatic release if that CI scripting work is submitted or if I can find the time to do it

git status

^[]2;git status^G^[]1;git^G^[]133;C;^GOn branch master^M
Your branch is up to date with 'origin/master'.^M
^M
Untracked files:^M
  (use "git add <file>..." to include in what will be committed)^M
    ^[[31m.benchmarks/^[[m^M
    ^[[31m.python-version^[[m^M
    ^[[31m.venv^[[m^M
    ^[[31m.vscode/^[[m^M
    ^[[31mDESIGN^[[m^M
    ^[[31mPATCH^[[m^M
    ^[[31mPATCH2^[[m^M
    ^[[31moutput.json^[[m^M
    ^[[31mtypescript^[[m^M
^M
nothing added to commit but untracked files present (use "git add" to track)^M

build

Command was python -m build --sdist --wheel

eel^[[10;92Hl^[[11;23Hl^[[12;10Hl^[[24;32H^[[37m^[[40ml^[[13;3H^[[39;49m^[(B^[[m^[[?1h^[=^[[24;33H^[[?25l^[[24;12H^[[37m^[[40mCurrent #1 (of #11 entries)^[[13;3H^[[39;49m^[(B^[[m^[[?1h^[=^[[24;39H^[[H^[[J^[[25;1H^[[?1049l^M^[[?1l^[>^[[?12;25h^[[?12l^[[?25h^M^M^[[0m^[[27m^[[24m^[[J^[]133;A^G(wcwidth-sarr) Code/wcwidth ^[[00m^[[37m[master^[[31m●^[[37m]^[[00m »^[[0m ^[]133;B^Gpython -m build --sdist --wheel^[[K^[[?1l^[>^[[?2004l^M^M
^[]2;python -m build --sdist --wheel^G^[]1;python^G^[]133;C;^G^[[1m* Creating venv isolated environment...^[[0m^M
^[[1m* Installing packages in isolated environment... (setuptools >= 40.8.0, wheel)^[[0m^M
^[[1m* Getting build dependencies for sdist...^[[0m^M
running egg_info^M
writing wcwidth.egg-info/PKG-INFO^M
writing dependency_links to wcwidth.egg-info/dependency_links.txt^M
writing requirements to wcwidth.egg-info/requires.txt^M
writing top-level names to wcwidth.egg-info/top_level.txt^M
reading manifest file 'wcwidth.egg-info/SOURCES.txt'^M
reading manifest template 'MANIFEST.in'^M
adding license file 'LICENSE'^M
writing manifest file 'wcwidth.egg-info/SOURCES.txt'^M
^[[1m* Building sdist...^[[0m^M
running sdist^M
running egg_info^M
writing wcwidth.egg-info/PKG-INFO^M
writing dependency_links to wcwidth.egg-info/dependency_links.txt^M
writing requirements to wcwidth.egg-info/requires.txt^M
writing top-level names to wcwidth.egg-info/top_level.txt^M
reading manifest file 'wcwidth.egg-info/SOURCES.txt'^M
reading manifest template 'MANIFEST.in'^M
adding license file 'LICENSE'^M
writing manifest file 'wcwidth.egg-info/SOURCES.txt'^M
running check^M
creating wcwidth-0.2.11^M
creating wcwidth-0.2.11/bin^M
creating wcwidth-0.2.11/code_templates^M
creating wcwidth-0.2.11/docs^M
creating wcwidth-0.2.11/tests^M
creating wcwidth-0.2.11/wcwidth^M
creating wcwidth-0.2.11/wcwidth.egg-info^M
copying files to wcwidth-0.2.11...^M
copying LICENSE -> wcwidth-0.2.11^M
copying MANIFEST.in -> wcwidth-0.2.11^M
copying README.rst -> wcwidth-0.2.11^M
copying requirements-develop.txt -> wcwidth-0.2.11^M
copying requirements-docs.in -> wcwidth-0.2.11^M
copying requirements-tests36.txt -> wcwidth-0.2.11^M
copying requirements-tests37.in -> wcwidth-0.2.11^M
copying requirements-tests37.txt -> wcwidth-0.2.11^M
copying requirements-tests39.in -> wcwidth-0.2.11^M
copying requirements-tests39.txt -> wcwidth-0.2.11^M
copying requirements-update.in -> wcwidth-0.2.11^M
copying requirements-update.txt -> wcwidth-0.2.11^M
copying setup.cfg -> wcwidth-0.2.11^M
copying setup.py -> wcwidth-0.2.11^M
copying tox.ini -> wcwidth-0.2.11^M
copying bin/new-wide-by-version.py -> wcwidth-0.2.11/bin^M
copying bin/update-tables.py -> wcwidth-0.2.11/bin^M
copying bin/verify-table-integrity.py -> wcwidth-0.2.11/bin^M
copying bin/wcwidth-browser.py -> wcwidth-0.2.11/bin^M
copying bin/wcwidth-libc-comparator.py -> wcwidth-0.2.11/bin^M
copying code_templates/python_table.py.j2 -> wcwidth-0.2.11/code_templates^M
copying code_templates/python_table_width.py.j2 -> wcwidth-0.2.11/code_templates^M
copying code_templates/unicode_version.rst.j2 -> wcwidth-0.2.11/code_templates^M
copying code_templates/unicode_versions.py.j2 -> wcwidth-0.2.11/code_templates^M
copying docs/api.rst -> wcwidth-0.2.11/docs^M
copying docs/conf.py -> wcwidth-0.2.11/docs^M
copying docs/index.rst -> wcwidth-0.2.11/docs^M
copying docs/intro.rst -> wcwidth-0.2.11/docs^M
copying docs/requirements.txt -> wcwidth-0.2.11/docs^M
copying docs/specs.rst -> wcwidth-0.2.11/docs^M
copying docs/unicode_version.rst -> wcwidth-0.2.11/docs^M
copying tests/__init__.py -> wcwidth-0.2.11/tests^M
copying tests/emoji-variation-sequences.txt -> wcwidth-0.2.11/tests^M
copying tests/emoji-zwj-sequences.txt -> wcwidth-0.2.11/tests^M
copying tests/test_core.py -> wcwidth-0.2.11/tests^M
copying tests/test_emojis.py -> wcwidth-0.2.11/tests^M
copying tests/test_ucslevel.py -> wcwidth-0.2.11/tests^M
copying wcwidth/__init__.py -> wcwidth-0.2.11/wcwidth^M
copying wcwidth/table_vs16.py -> wcwidth-0.2.11/wcwidth^M
copying wcwidth/table_wide.py -> wcwidth-0.2.11/wcwidth^M
copying wcwidth/table_zero.py -> wcwidth-0.2.11/wcwidth^M
copying wcwidth/unicode_versions.py -> wcwidth-0.2.11/wcwidth^M
copying wcwidth/wcwidth.py -> wcwidth-0.2.11/wcwidth^M
copying wcwidth.egg-info/PKG-INFO -> wcwidth-0.2.11/wcwidth.egg-info^M
copying wcwidth.egg-info/SOURCES.txt -> wcwidth-0.2.11/wcwidth.egg-info^M
copying wcwidth.egg-info/dependency_links.txt -> wcwidth-0.2.11/wcwidth.egg-info^M
copying wcwidth.egg-info/requires.txt -> wcwidth-0.2.11/wcwidth.egg-info^M
copying wcwidth.egg-info/top_level.txt -> wcwidth-0.2.11/wcwidth.egg-info^M
copying wcwidth.egg-info/zip-safe -> wcwidth-0.2.11/wcwidth.egg-info^M
copying wcwidth.egg-info/SOURCES.txt -> wcwidth-0.2.11/wcwidth.egg-info^M
Writing wcwidth-0.2.11/setup.cfg^M
Creating tar archive^M
removing 'wcwidth-0.2.11' (and everything under it)^M
^[[1m* Creating venv isolated environment...^[[0m^M
^[[1m* Installing packages in isolated environment... (setuptools >= 40.8.0, wheel)^[[0m^M
^[[1m* Getting build dependencies for wheel...^[[0m^M
running egg_info^M
writing wcwidth.egg-info/PKG-INFO^M
writing dependency_links to wcwidth.egg-info/dependency_links.txt^M
writing requirements to wcwidth.egg-info/requires.txt^M
writing top-level names to wcwidth.egg-info/top_level.txt^M
reading manifest file 'wcwidth.egg-info/SOURCES.txt'^M
reading manifest template 'MANIFEST.in'^M
adding license file 'LICENSE'^M
writing manifest file 'wcwidth.egg-info/SOURCES.txt'^M
^[[1m* Installing packages in isolated environment... (wheel)^[[0m^M
^[[1m* Building wheel...^[[0m^M
running bdist_wheel^M
running build^M
running build_py^M
copying wcwidth/wcwidth.py -> build/lib/wcwidth^M
copying wcwidth/table_zero.py -> build/lib/wcwidth^M
copying wcwidth/__init__.py -> build/lib/wcwidth^M
copying wcwidth/table_vs16.py -> build/lib/wcwidth^M
copying wcwidth/table_wide.py -> build/lib/wcwidth^M
copying wcwidth/unicode_versions.py -> build/lib/wcwidth^M
installing to build/bdist.macosx-12.5-arm64/wheel^M
running install^M
running install_lib^M
creating build/bdist.macosx-12.5-arm64/wheel^M
creating build/bdist.macosx-12.5-arm64/wheel/wcwidth^M
copying build/lib/wcwidth/wcwidth.py -> build/bdist.macosx-12.5-arm64/wheel/wcwidth^M
copying build/lib/wcwidth/table_zero.py -> build/bdist.macosx-12.5-arm64/wheel/wcwidth^M
copying build/lib/wcwidth/__init__.py -> build/bdist.macosx-12.5-arm64/wheel/wcwidth^M
copying build/lib/wcwidth/emoji_zwj_sequences.py -> build/bdist.macosx-12.5-arm64/wheel/wcwidth^M
copying build/lib/wcwidth/table_vs16.py -> build/bdist.macosx-12.5-arm64/wheel/wcwidth^M
copying build/lib/wcwidth/unicode_versions.pyi -> build/bdist.macosx-12.5-arm64/wheel/wcwidth^M
copying build/lib/wcwidth/wcwidth.pyi -> build/bdist.macosx-12.5-arm64/wheel/wcwidth^M
copying build/lib/wcwidth/py.typed -> build/bdist.macosx-12.5-arm64/wheel/wcwidth^M
copying build/lib/wcwidth/table_wide.py -> build/bdist.macosx-12.5-arm64/wheel/wcwidth^M
copying build/lib/wcwidth/unicode_versions.py -> build/bdist.macosx-12.5-arm64/wheel/wcwidth^M
copying build/lib/.DS_Store -> build/bdist.macosx-12.5-arm64/wheel^M
running install_egg_info^M
running egg_info^M
writing wcwidth.egg-info/PKG-INFO^M
writing dependency_links to wcwidth.egg-info/dependency_links.txt^M
writing requirements to wcwidth.egg-info/requires.txt^M
writing top-level names to wcwidth.egg-info/top_level.txt^M
reading manifest file 'wcwidth.egg-info/SOURCES.txt'^M
reading manifest template 'MANIFEST.in'^M
adding license file 'LICENSE'^M
writing manifest file 'wcwidth.egg-info/SOURCES.txt'^M
Copying wcwidth.egg-info to build/bdist.macosx-12.5-arm64/wheel/wcwidth-0.2.11-py3.12.egg-info^M
running install_scripts^M
creating build/bdist.macosx-12.5-arm64/wheel/wcwidth-0.2.11.dist-info/WHEEL^M
creating '/Users/jq/Code/wcwidth/dist/.tmp-2veajiyp/wcwidth-0.2.11-py2.py3-none-any.whl' and adding 'build/bdist.macosx-12.5-arm64/wheel' to it^M
adding '.DS_Store'^M
adding 'wcwidth/__init__.py'^M
adding 'wcwidth/emoji_zwj_sequences.py'^M
adding 'wcwidth/py.typed'^M
adding 'wcwidth/table_vs16.py'^M
adding 'wcwidth/table_wide.py'^M
adding 'wcwidth/table_zero.py'^M
adding 'wcwidth/unicode_versions.py'^M
adding 'wcwidth/unicode_versions.pyi'^M
adding 'wcwidth/wcwidth.py'^M
adding 'wcwidth/wcwidth.pyi'^M
adding 'wcwidth-0.2.11.dist-info/LICENSE'^M
adding 'wcwidth-0.2.11.dist-info/METADATA'^M
adding 'wcwidth-0.2.11.dist-info/WHEEL'^M
adding 'wcwidth-0.2.11.dist-info/top_level.txt'^M
adding 'wcwidth-0.2.11.dist-info/zip-safe'^M
adding 'wcwidth-0.2.11.dist-info/RECORD'^M
removing build/bdist.macosx-12.5-arm64/wheel^M
^[[1m^[[92mSuccessfully built ^[[4mwcwidth-0.2.11.tar.gz^[[0m^[[1m^[[92m and ^[[4mwcwidth-0.2.11-py2.py3-none-any.whl^[[0m^[[1m^[[92m^[[0m^M

jquast added a commit that referenced this issue Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants