Keydown triggers the selectDates function

[yalperg]

Check that this is really a bug

• I confirm

Reproduction link

n/a

Bug description

First double click on the slot, then click on a slot and finally press any key on the keyboard. This triggers the selectDates function and causes an error.

Here is the demo:

Ekran.Kaydi.2024-04-06.01.41.24.mov

I think this problem is caused by the _handleTerminatingEvent function, the keydown event listener is added for the escape key, but there is no control for other keys, so it emits the select event when other keys are pressed.

react-big-calendar/src/Selection.js

Lines 340 to 373 in 72a0147

	_handleTerminatingEvent(e) {
	const selecting = this.selecting
	const bounds = this._selectRect
	// If it's not in selecting state, it's a click event
	if (!selecting && e.type.includes('key')) {
	e = this._initialEvent
	}
	this.selecting = false
	this._removeEndListener && this._removeEndListener()
	this._removeMoveListener && this._removeMoveListener()
	this._selectRect = null
	this._initialEvent = null
	this._initialEventData = null
	this._lastClickData = null
	if (!e) return
	let inRoot = !this.container || contains(this.container(), e.target)
	let isWithinValidContainer = this._isWithinValidContainer(e)
	if (e.key === 'Escape' || !isWithinValidContainer) {
	return this.emit('reset')
	}
	if (!selecting && inRoot) {
	return this._handleClickEvent(e)
	}
	// User drag-clicked in the Selectable area
	if (selecting) return this.emit('select', bounds)
	return this.emit('reset')
	}

react-big-calendar/src/Selection.js

Lines 302 to 305 in 72a0147

	this._onEscListener = addEventListener(
	'keydown',
	this._handleTerminatingEvent
	)

Expected Behavior

No response

Actual Behavior

No response

react-big-calendar version

1.11.2

React version

18.2

Platform/Target and Browser Versions

macOS

Validations

• Read the docs.
• Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
• Make sure this is a react-big-calendar issue and not an implementation issue

Would you like to open a PR for this bug?

• I'm willing to open a PR

[forceddd]

@yuiji Does this issue still exist on version 1.11.3? I have not been able to successfully reproduce this error.

[yalperg]

@forceddd I checked again and this issue does not exist on version 1.11.3. I think this PR (#2551) solved this issue, right?

[forceddd]

@yuiji Yes, that's what it looks like right now.