Fix/issue 2424 #2551
Merged
Fix/issue 2424 #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@forceddd This is a good start, addressing selection issues in the Month view. But, there are still issues with selection in the TimeGrid view that seem to revolve around your changes with SlotMetrics. |
@cutterbl Would you like to check this pr.I think this pr can fix these bugs related to my previous change. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's created for the issue 2424
I modified some logic in the
Selector. When this happens, theSelectorwill emit theclickevent, and every time it terminates, the previous state will be cleared.before:
2024-04-02.15.13.55.mov
after:
2024-04-02.15.37.21.mov