Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent endless loop when adding event the DST begin day #1635

Merged
merged 2 commits into from
Apr 20, 2020
Merged

Prevent endless loop when adding event the DST begin day #1635

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
815dba0
Prevent endless loop when adding event the DST begin day
jeanlazarou Apr 11, 2020
0a8717f
Add a comment for the reason of the change
jeanlazarou Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DayColumn.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ class DayColumn extends React.Component {

while (dates.lte(current, endDate)) {
slots.push(current)
current = dates.add(current, this.props.step, 'minutes')
current = new Date(+current + this.props.step * 60 * 1000)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is fine but lets add a comment explaining why here in the event this is addressed upstream

}

notify(this.props.onSelectSlot, {
Expand Down