Documentation: clarify the time unit for 'step' #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `step` property accepts minutes but this is not explicitly mentioned. Although the default value of `30` suggests that minutes should be given, this is not immediately obvious.
jquense
approved these changes
Jul 12, 2020
|
thanks! |
|
🎉 This PR is included in version 0.26.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Teal-labs-developer
pushed a commit
to Teal-labs-developer/react-big-calendar
that referenced
this pull request
Nov 11, 2020
…into react-big-calendar-v0-28-6 * 'master' of https://github.com/jquense/react-big-calendar: (106 commits) fix: revert a bug that the height of the column is broken when displayed in IE11 (jquense#1789)" (jquense#1805) fix: bug with resize segments not being removed (jquense#1800) fix: preserve time on horizontal resizing (jquense#1795) Update README.md (jquense#1799) fix: enforce `resizable` prop (jquense#1796) fix: a bug that the height of the column is broken when displayed in IE11 (jquense#1789) Use main Reactiflux invite (jquense#1780) fix: item preview inside cell while dragging from outside not working… (jquense#1770) fix onKeyPressEvent should not be required (jquense#1767) feat: add onKeyPressEvent (jquense#1754) chore(deps): bump handlebars from 4.1.2 to 4.7.6 (jquense#1745) feat: add resourceId to handleSelectAllDaySlot fns slotInfo (jquense#1735) fix: Fix top part of 24hour event in week/day view (jquense#1732) intljusticemission renamed to jquense (jquense#1710) docs: little documentation clarification (jquense#1700) docs: update README.md (jquense#1690) feat: starting to hooks to avoid deprecation warnings (jquense#1687) docs: fixed return type for View parameter (jquense#1677) feat: add dragging ability from the monthly Popup component (jquense#1554) fix: hide indicator when current time is not in the interval (jquense#1639) ... # Conflicts: # .size-snapshot.json # src/Calendar.js # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
stepproperty accepts minutes but this is not explicitly mentioned. Although the default value of30suggests that minutes should be given, this is not immediately obvious.