Remove 'resize' event listener on TimeGrid unmount #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arecvlohe
reviewed
Feb 23, 2018
| } | ||
|
|
||
| componentWillUnmount() { | ||
| window.clearTimeout(this._timeIndicatorTimeout) | ||
| window.removeEventListener('resize', this.handleResize) | ||
|
|
||
| raf.cancel(this.rafHandle) |
There was a problem hiding this comment.
Is raf some global? I am not familiar with the API.
There was a problem hiding this comment.
The actual api used is requestAnimationFrame the helper here is from dom-helpers and is a bit more cross browser resilient
|
I've been having this issue, would appreciate if this got merged in |
arecvlohe
approved these changes
Mar 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #725