Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateSnapshot Sample replaced with ReadOnly #6

Closed
wants to merge 3 commits into from
Closed

CreateSnapshot Sample replaced with ReadOnly #6

wants to merge 3 commits into from

Conversation

zjack8
Copy link
Collaborator

@zjack8 zjack8 commented Oct 18, 2023

No description provided.

IanZYYap
IanZYYap reviewed Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@IanZYYap IanZYYap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think you could port the sample's contents into the test case instead of calling the main method, and then add a few assertions, i.e assert that readOnlySetting and clearedReadOnlySetting are not null?

@zjack8 zjack8 closed this Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanZYYap IanZYYap IanZYYap left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zjack8 @IanZYYap