Spoon snapshot #25
Spoon snapshot #25
Conversation
|
Nice work thanks! As I see the project is a bit deprecated so I will try to submit update PR for the emulator on Travis, which is now failing. |
|
I am trying to implement FalconSpoon in my project, but it is not compatible with spoon's latest version. I saw that there is a PR on the matter, so my question is when is going to be merged? |
|
Hello @IrenaMystic, I got no response from lebzuch since I commented, because there are small changes required. I might do them by myself once I find time for it, but if you are faster please feel free to copy the repo from lebzuch and do these changes. Thanks for the comment I will try to do the changes, but it can take few days I'm bit busy these days. |
|
Hi @jraska,
so I'm waiting for it :) |
|
FalconSpoonRule.java has a comment :) |
|
I don't know if I'm blind or sth but I cannot see it... |
| * Utility class which simply uses Spoon API to obtain desired file | ||
| * and then write there Falcon screenshot | ||
| */ | ||
| public final class FalconSpoonRule { |
There was a problem hiding this comment.
Hello, thank you for the PR! great work, however I would suggest FalconSpoonRule to wrap SpoonRule and delegating the rule methods to wrapped instance.
The motivation is to allow developers only change SpoonRule to FalconSpoonRule in a codebase and to avoid adding the SpoonRule as a parameter of screenshot method, again to not force user to change anything.
|
Wow! My bad! I did the comment, submitted and then there is extra step clicking the submit button again. Sorry for that! |
|
Awesome! Thank you very much. 👍 Whole Travis build seems broken by time so I will accept the PR now, which will force me to update the tests and build files soon probably over weekend. There will be new release of FalconSpoon after that with major version update. Thanks again for help. |
|
@lebzuch , @IrenaMystic Version 2.0.0 released. |
Android Studio 3.0 didn't work with spoon 1.* so I handle latest snapshot of spoon client.