Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get tests running again #5

Merged
merged 3 commits into from
Dec 4, 2023
Merged

get tests running again #5

merged 3 commits into from
Dec 4, 2023

Conversation

jrochkind
Copy link
Owner

@jrochkind jrochkind commented Dec 4, 2023 •
edited
Loading

Haven't touched this in a while, as usual I find that CI is not green. Let's fix.

  • aws gem now has implicit dependency on an XML processor such as nokogiri, add for dev
  • response-expires header format match recent AWS ruby SDK with #httpdate

@jrochkind jrochkind changed the title aws gem now has implicit dependency on an XML processor such as get tests running again Dec 4, 2023
@jrochkind
Copy link
Owner Author

Oh wow, there's an actual test failure... AWS gem is now using a different time format for response-expires header... let's change to match.

@jrochkind
Copy link
Owner Author

Ha, that date format change was a result of an issue we ourselves filed with ruby AWS sdk! aws/aws-sdk-ruby#2415

@jrochkind jrochkind merged commit 1a149e2 into master Dec 4, 2023
1 check passed
@jrochkind jrochkind deleted the nokogiri_dev_dep branch December 4, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrochkind