Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jdbc to 42.7.1 #1141

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

skunkworker
Copy link
Contributor

@skunkworker skunkworker commented Jan 30, 2024

Since this is a jar, this is fine to be closed for a contributor to update the jar (I understand for security concerns etc).

@enebo enebo merged commit 180bdfe into jruby:master Jan 30, 2024
1 of 13 checks passed
@enebo
Copy link
Member

enebo commented Jan 30, 2024

@skunkworker I verified it is the same file (so others watching will not think I blindly did this) but you also have been visibly working through a perf issue so I didn't expect it to be another file 😄

@enebo
Copy link
Member

enebo commented Jan 30, 2024

@kares never quite sure on how you evaluate some of these updates and whether we go with it or skip.

@kares
Copy link
Member

kares commented Jan 31, 2024

@enebo used to check the CI or test locally against AR-JDBC to see if everything works before merging/releasing.
given CI has been 🔴 for a while (all PG tests do not even start 😰) might be a bit harder to tell how well the driver update is supported in terms of JRuby on Rails.

@enebo
Copy link
Member

enebo commented Jan 31, 2024

@kares yeah I should have had this rebased onto a stable branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants