Fix some arjdbc mysql tests to support AR 7.1 #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it used to be ActiveRecord::Result, now it seems to be an array
<ActiveRecord::StatementInvalid> expected but was <ActiveRecord::JDBCError(<java.sql.SQLSyntaxErrorException: BLOB, TEXT, GEOMETRY or JSON column 'about' can't have a default value>)
|
@JesseChavez cool! You may have noticed this but the local tests are basically a subset of tests ripped out of Rails unit tests from many many years ago. As time moves forward tests get removed or updated for behavior. I think there is still value with these as they are a good selection of basic behavior and simpler to green before the full AR test suite. You can see from actual Rails test unit runs they do not catch a lot of stuff either. Just some background. |
|
@JesseChavez Thank you! We really appreciate the help here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @headius & @enebo
Here we have more fixes.
Hopefully we will have mysql tests green.