Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some arjdbc postgres tests to support AR 7.1 #1153

Merged
merged 8 commits into from
Jul 31, 2024

Conversation

JesseChavez
Copy link
Contributor

Hi @headius & @enebo

Hopefully we will have postgres arjdbc tests green.

In the next coming days I will look at Rails tests

TypeError: wrong argument type Hash (expected IO)

there was nothing wrong, hstore has its own serializer and deserializer
(no json or yaml)
- now there are 2 types, timestamp and timestamptz
- it became pg gem specific when composite keys support was added
- conKey and confkey and not casted by pg gem.
@enebo enebo merged commit 81506f0 into jruby:master Jul 31, 2024
3 of 13 checks passed
@enebo
Copy link
Member

enebo commented Jul 31, 2024

@JesseChavez Looks like only one test now complaining about Time.zone leaking. That is great though. Local tests are nearly perfect now.

@JesseChavez JesseChavez deleted the rails_71_support_arjdbc_postgres branch July 31, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants