Migrate plugin to use dry-struct from virtus #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpiggott
commented
Aug 11, 2022
| @@ -20,6 +20,6 @@ | |||
| # | |||
| module Maven | |||
| module Tools | |||
| VERSION = '1.1.7'.freeze | |||
| VERSION = '1.2.0'.freeze | |||
There was a problem hiding this comment.
I figured 1.2 due to the dependency changes
mpiggott
commented
Aug 11, 2022
Comment on lines
+31
to
+37
| s.add_runtime_dependency 'dry-container', '~> 0.7.2' | ||
| s.add_runtime_dependency 'dry-configurable', '~> 0.12.1' | ||
| s.add_runtime_dependency 'dry-core', '~> 0.6.0' | ||
| s.add_runtime_dependency 'dry-inflector', '~> 0.2.0' | ||
| s.add_runtime_dependency 'dry-types', '~> 1.5.1' | ||
| s.add_runtime_dependency 'dry-struct', '~> 1.4.0' | ||
| s.add_runtime_dependency 'dry-struct-setters', '~> 0.4.0' |
There was a problem hiding this comment.
These were the dependency versions whose releases worked on the version of Ruby in the JRuby dependency
mpiggott
commented
Aug 11, 2022
| @@ -19,17 +19,8 @@ | |||
| </scm> | |||
| <repositories> | |||
| <repository> | |||
| <id>rubygems</id> | |||
| <name>Rubygems Proxy</name> | |||
| <url>http://rubygems-proxy.torquebox.org/releases</url> | |||
There was a problem hiding this comment.
The torquebox domain lapsed recently
mpiggott
commented
Aug 11, 2022
| <type>gem</type> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>rubygems</groupId> | ||
| <artifactId>rake</artifactId> | ||
| <version>[10.0,10.99999]</version> |
There was a problem hiding this comment.
Version ranges didn't seem to work with wagon
mpiggott
commented
Aug 11, 2022
| Maven::Tools::Artifact.from_coordinate( 'sdas:das:jar:123:[de:fr,gb:us]' ).to_s.must_equal 'sdas:das:jar:123:[de:fr,gb:us]' | ||
| Maven::Tools::Artifact.from_coordinate( 'sdas:das:jar:tes:[123,234]:[de:fr,gb:us]' ).to_s.must_equal 'sdas:das:jar:tes:[123,234]:[de:fr,gb:us]' | ||
| Maven::Tools::Artifact.from_coordinate( 'sdas:das:jar:[123,234]:[de:fr,gb:us]' ).to_s.must_equal 'sdas:das:jar:[123,234]:[de:fr,gb:us]' | ||
| _(Maven::Tools::Artifact.from_coordinate( 'sdas:das:jar:tes:123' ).to_s).must_equal 'sdas:das:jar:tes:123' |
There was a problem hiding this comment.
minitest was complaining about deprecated calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, while attempting to upgrade Nexus Repository Manager 2 to a newer version of JRuby I ran into some issues caused by axiom-types (a dependency of virtus) it appears it does not work on newer versions of Ruby. It appears that that library has been abandoned by its authors (a PR fixing it was opened 5-years ago).
I'll lead with - I'm not a ruby programmer, I've never touched it before but I've made an attempt here to switch from the also deprecated virtus to its successor dry-struct. AFAICT in the context of Nexus my changes work.
However dry-struct inserts fields into a Hash thus doesn't maintain order and results in POMs whose elements are in an arbitrary order. With my limited knowledge of ruby I wasn't able to figure out a way to iterate over the fields in the defined order, though I suspect its possible.
The obvious issue here is that this leads to test failures, I have other changes which attempt to resolve that by making the expected test results match the arbitrary ordering though I wasn't able to resolve all the issues (the expected output is used for multiple tests which generate different arbitrary ordering)