-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zh-cn-ydk.js.org #8368
zh-cn-ydk.js.org #8368
Conversation
liunnn1994
commented
Jul 12, 2023
- There is reasonable content on the page (see: No Content)
- I have read and accepted the Terms and Conditions
👋 This appears to be a translated fork of https://github.com/getify/You-Dont-Know-JS -- do you have permission from the original author to be publishing this? If you do, could I suggest that you request |
cc @getify I suspect this violates the no derivatives part of the license you published your original content under? |
This contributor does have permission to do the chinese translations and has been promoted as collaborator on the repo. However, I concur with Matt that wanting to register a specific (sub) domain to host the content would be preferable to indicate it's not the official original book text.
|
@getify @MattIPv4 I'm sorry to bother you guys. The reason I didn't put the original version online at the same time is that some of the makrdown syntax isn't compatible with the vitepress framework I'm using! For example, I replaced And I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Commit valid, site has content based on https://ydkjsy-zh.netlify.app/
I trust that your site is configured ready to work with the requested js.org subdomain.
I've already added your requested subdomain to JS.ORGs zonefile. You may have to configure your host to accept the custom domain. |
@indus Done, thnx |
Welcome https;//zh-cn-ydk.js.org |