Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-cn-ydk.js.org #8368

Merged
merged 1 commit into from
Jul 13, 2023
Merged

zh-cn-ydk.js.org #8368

merged 1 commit into from
Jul 13, 2023

Conversation

liunnn1994
Copy link
Contributor

@MattIPv4
Copy link
Member

👋 This appears to be a translated fork of https://github.com/getify/You-Dont-Know-JS -- do you have permission from the original author to be publishing this?

If you do, could I suggest that you request zh-cn-you-dont-know.js.org or similar, to make it clear this is a translation, rather than trying to appear as if this is the original?

@MattIPv4 MattIPv4 added the awaiting response This PR is waiting for a response from the requester label Jul 12, 2023
@MattIPv4
Copy link
Member

cc @getify I suspect this violates the no derivatives part of the license you published your original content under?

@getify
Copy link

getify commented Jul 12, 2023

This contributor does have permission to do the chinese translations and has been promoted as collaborator on the repo.

However, I concur with Matt that wanting to register a specific (sub) domain to host the content would be preferable to indicate it's not the official original book text.

  • zh-cn-you-dont-know.js.org works fine
  • zh-cn-ydk.js.org seems even better to me

@liunnn1994
Copy link
Contributor Author

@getify @MattIPv4 I'm sorry to bother you guys. The reason I didn't put the original version online at the same time is that some of the makrdown syntax isn't compatible with the vitepress framework I'm using! For example, I replaced <enter> with enter.

And I think zh-cn-ydk.js.org is better for me.

@liunnn1994 liunnn1994 changed the title you-dont-know.js.org zh-cn-ydk.js.org Jul 12, 2023
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, site has content based on https://ydkjsy-zh.netlify.app/

I trust that your site is configured ready to work with the requested js.org subdomain.

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages and removed awaiting response This PR is waiting for a response from the requester labels Jul 12, 2023
@indus indus added the error The page requested returns an error label Jul 12, 2023
@indus
Copy link
Member

indus commented Jul 12, 2023

I've already added your requested subdomain to JS.ORGs zonefile. You may have to configure your host to accept the custom domain.
I'll merge after we have "contact". Please keep this PR open.

@liunnn1994
Copy link
Contributor Author

@indus Done, thnx

@indus indus removed the error The page requested returns an error label Jul 13, 2023
@indus
Copy link
Member

indus commented Jul 13, 2023

Welcome https;//zh-cn-ydk.js.org

@indus indus merged commit 30cad2a into js-org:master Jul 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants