Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrollery.js.org #8386

Merged
merged 2 commits into from
Jul 19, 2023
Merged

scrollery.js.org #8386

merged 2 commits into from
Jul 19, 2023

Conversation

nguyend-nam
Copy link
Contributor

The external page is deployed at: https://scrollery.netlify.app/.
The aim is to create a ReactJS library for scroll animation.

@MattIPv4 MattIPv4 changed the title feat: add scrollery domain scrollery.js.org Jul 19, 2023
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, site has content based on https://scrollery.netlify.app/

I trust that your site is configured ready to work with the requested js.org subdomain.

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages labels Jul 19, 2023
@indus indus added the error The page requested returns an error label Jul 19, 2023
@indus
Copy link
Member

indus commented Jul 19, 2023

I've already added your requested subdomain to JS.ORGs zonefile. You may have to configure your host to accept the custom domain.
I'll merge after we have "contact". Please keep this PR open.

@nguyend-nam
Copy link
Contributor Author

I've already added your requested subdomain to JS.ORGs zonefile. You may have to configure your host to accept the custom domain. I'll merge after we have "contact". Please keep this PR open.

Thank you so much. Am I configuring the subdomain correctly?

image

@indus indus removed the error The page requested returns an error label Jul 19, 2023
@indus
Copy link
Member

indus commented Jul 19, 2023

LGTM
Welcome https://scrollery.js.org

@indus indus merged commit 4b24722 into js-org:master Jul 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants