Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isadb.js.org #8443

Merged
merged 5 commits into from
Aug 19, 2023
Merged

isadb.js.org #8443

merged 5 commits into from
Aug 19, 2023

Conversation

renato425
Copy link
Contributor

@renato425
Copy link
Contributor Author

Omg! I forgot to send the project.
Here it is: https://guilhermeesquecirufino.gitbook.io/docs-isadb2/

@indus
Copy link
Member

indus commented Aug 17, 2023

@renato425 would you mind to explain me what your page is about and how it is related to JavaScript?

@indus indus added the awaiting response This PR is waiting for a response from the requester label Aug 17, 2023
@renato425
Copy link
Contributor Author

Oh sorry
So, I have a database project (library) for NodeJS (IsaDB2). I can even send the repository over here... I wanted the domain for this purpose

@renato425
Copy link
Contributor Author

If you want more information, pls. Reply me

@renato425
Copy link
Contributor Author

An update on GitBook: I updated the documentation, now there are more examples and a tutorial in the middle (the problem is that it is in Portuguese. So, try to use the translator)

@indus
Copy link
Member

indus commented Aug 18, 2023

@renato425 I've added your requested subdomain and target as you've noted it. But becaus this is gitbook it propably won't won't work. Gitbook usualy uses "hosting.gitbook.io" as target. See: #5407 (comment)
You most likely will have to change this and wait for me to change it in JS.ORGs DNS zonefile as well.

@renato425
Copy link
Contributor Author

I'm thinking of turning GitBook markdown to Github Pages, I'll do that and get back to you.

@renato425
Copy link
Contributor Author

"Atualized": https://renato425.github.io/isadb.github.io

@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account awaiting CNAME This PR is waiting for the target to add a CNAME file and removed awaiting response This PR is waiting for a response from the requester labels Aug 18, 2023
@indus
Copy link
Member

indus commented Aug 18, 2023

I've just changed your requested subdomain in JS.ORGs zonefile. For some reason the CNAME you have added to the gh-pages branch was not properly evaluated by GitHub. Please try to remove the CNAME everywhere and re-add it afterwards (or use the page settings of your repo to do so)
I'll merge after we have "contact". Please keep this PR open.

@renato425
Copy link
Contributor Author

Welcome! https://isadb.js.org

@indus indus merged commit b3280a8 into js-org:master Aug 19, 2023
1 check passed
@indus indus removed the awaiting CNAME This PR is waiting for the target to add a CNAME file label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants