Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shell quoting that stopped the alias command from working in zsh. #239

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Fix shell quoting that stopped the alias command from working in zsh. #239

merged 1 commit into from
Apr 14, 2023

Conversation

12wrigja
Copy link
Contributor

No description provided.

@12wrigja
Copy link
Contributor Author

As mentioned in #236, the existing command didn't work in zsh because it needs to be properly quoted there. Not really sure why it worked in bash to begin with.

@ptomato
Copy link
Contributor

ptomato commented Apr 13, 2023

As mentioned in #236, the existing command didn't work in zsh because it needs to be properly quoted there. Not really sure why it worked in bash to begin with.

I think $() is its own quoting in bash, apparently not in zsh?

justingrant
justingrant approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@justingrant justingrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@12wrigja 12wrigja merged commit 96f411b into js-temporal:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justingrant justingrant justingrant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@12wrigja @ptomato @justingrant